Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new misc-check that no two top-level node from any two modules conflict in name #69

Open
wenovus opened this issue Dec 1, 2021 · 1 comment
Open

Add new misc-check that no two top-level node from any two modules conflict in name #69

wenovus opened this issue Dec 1, 2021 · 1 comment
Assignees
@wenovus

Comments

@wenovus
Copy link
Contributor

wenovus commented Dec 1, 2021

Also need to make sure their ygot names don't conflict either. This is more restrictive so can just use this as the sole check.
@wenovus wenovus self-assigned this Dec 1, 2021
@wenovus
Copy link
Contributor Author

wenovus commented Jan 27, 2022

In the same PR we should also say the path of the old file. This check only compares the module names so if it happens to be a different path it can be confusing: https://github.com/openconfig/public/pull/568/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wenovus wenovus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wenovus