From ba05c4f5be5bf90f9aecb586aae9774d5e1d0f9c Mon Sep 17 00:00:00 2001 From: "Matthew Starkey (mastarke)" Date: Thu, 19 Dec 2024 12:02:20 -0800 Subject: [PATCH 1/2] modifed TC5 final port up check as timing was causing flaky results --- .../holdtime/otg_tests/holdtime_test/holddown_timers_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/feature/interface/holdtime/otg_tests/holdtime_test/holddown_timers_test.go b/feature/interface/holdtime/otg_tests/holdtime_test/holddown_timers_test.go index 913505b0063..bb05be343a3 100644 --- a/feature/interface/holdtime/otg_tests/holdtime_test/holddown_timers_test.go +++ b/feature/interface/holdtime/otg_tests/holdtime_test/holddown_timers_test.go @@ -610,7 +610,7 @@ func TestTC5ShortDOWN(t *testing.T) { t.Run("Verify port status UP", func(t *testing.T) { t.Log("re-verify that the interface state is still up") - verifyPortsStatus(t, dut, "UP", 10) + verifyPortsStatus(t, dut, "UP", 30) }) } From dcce4ecfdfe649f8afa05a7ed9d74fcd809f2b20 Mon Sep 17 00:00:00 2001 From: Pramod Maurya Date: Mon, 6 Jan 2025 14:43:59 +0530 Subject: [PATCH 2/2] Update README.md --- .../otg_tests/holdtime_test/README.md | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/feature/interface/holdtime/otg_tests/holdtime_test/README.md b/feature/interface/holdtime/otg_tests/holdtime_test/README.md index d8b961a49e2..922d32e5cac 100644 --- a/feature/interface/holdtime/otg_tests/holdtime_test/README.md +++ b/feature/interface/holdtime/otg_tests/holdtime_test/README.md @@ -49,21 +49,23 @@ Verify oper-state behaviour * oper-status last change time has NOT changed * Stop sending Ethernet Remote Fault (RF) from OTG port-1 -## Config Parameter Coverage +## OpenConfig Path and RPC Coverage -* /interfaces/interface/hold-time/config/up -* /interfaces/interface/hold-time/config/down +The below yaml defines the OC paths and RPC intended to be covered by this test. -## Telemetry Parameter Coverage +```yaml +paths: + /interfaces/interface/hold-time/config/up: + /interfaces/interface/hold-time/config/down: + /interfaces/interface/state/oper-status: + /interfaces/interface/state/last-change: -* /interfaces/interface/hold-time/config/up -* /interfaces/interface/hold-time/config/down -* /interfaces/interface/state/oper-status -* /interfaces/interface/state/last-change - -## Protocol/RPC Parameter Coverage - -None +rpcs: + gnmi: + gNMI.Get: + gNMI.Set: + gNMI.Subscribe: +``` ## Minimum DUT Platform Requirement