Need clarification on Control Board numbering

[Kattasr]

From Bootz perspective, is slot "0" considered as invalid control board slot number?

When I dump JSON content of Bootz request in python script as shown below, it prints slot-1 number as "1" as expected.
But it doesnt print slot-0 number. So, suspecting that "0" is considered as invalid index.

json_obj = MessageToJson(request)
print(json_obj)

[gmacf]

Could you also provide the JSON dump and the input request?

[kattasrao]

I am not sure on how to provide "input request".
But providing JSON details.
In Juniper software, control board slot numbering starts from 0. When I encode slot number "0" on client, JSON dump on server skips printing slot number.

---

{
"chassisDescriptor": {
"manufacturer": "Juniper Networks",
"partNumber": "EH022",
"controlCards": [
{
"partNumber": "750-145341",
"serialNumber": "BCCV8646"
},
{
"partNumber": "750-145341",
"serialNumber": "BCCV8634",
"slot": 1
}
]
},
"controlCardState": {
"serialNumber": "BCCV8634",
"status": "CONTROL_CARD_STATUS_NOT_INITIALIZED"
},
"nonce": "x4vb5QUyDednzBhM"
}

---

So, to check, I changed client code to send slot numbers as 1 and 2 instead of slot 0 and 1.
Then JSON dump prints both slot numbers correctly.
So, looks like the JSON print function treats int value 0 for slot as invalid slot number.

---

{
"chassisDescriptor": {
"manufacturer": "Juniper Networks",
"partNumber": "EH022",
"controlCards": [
{
"partNumber": "750-145341",
"serialNumber": "BCCV8646",
"slot": 1
},
{
"partNumber": "750-145341",
"serialNumber": "BCCV8634",
"slot": 2
}
]
},
"controlCardState": {
"serialNumber": "BCCV8634",
"status": "CONTROL_CARD_STATUS_NOT_INITIALIZED"
},
"nonce": "nTjZc1hJqixCixOG"
}

---

[gmacf]

Yeah, this seems like an issue with the JSON dump function you're using. The Bootz code doesn't do any validation on the slot number passed by the client.

[kattasrao]

I was concerned that Bootz may be treating "0" as invalid slot. Thanks for clarification that it is not the case.
After a bit of searching, found that the JSON dump function from protobuf utils doesn't print default values by default.

But could override default dump behavior by forcing to print default values.

from google.protobuf.json_format import MessageToJson
json_obj = MessageToJson(request, including_default_value_fields=True)

Will close the issue as resolved.

[Kattasr]

Closing as per details provided in previous comment.