Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature.go should match Verify implementation and use crypto.PrivateKey #76

Closed
melzhan opened this issue Oct 18, 2023 · 1 comment
Closed

Comments

@melzhan
Copy link
Contributor

melzhan commented Oct 18, 2023

Signature.go Line 30:
To match the Verify() implementation, this should be a crypto.PrivateKey and then a type switch should be used to provide algorithm specific code paths.

Otherwise, if the current function signature gets traction, introducing an algorithm agnostic counterpart will end up being a bit cumbersome.

@gmacf
Copy link
Contributor

gmacf commented Oct 24, 2023

Fixed in #79

@gmacf gmacf closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants