Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc nits #68

Closed
melzhan opened this issue Oct 10, 2023 · 0 comments
Closed

Fix misc nits #68

melzhan opened this issue Oct 10, 2023 · 0 comments
Assignees

Comments

@melzhan
Copy link
Contributor

melzhan commented Oct 10, 2023

Comments copied from internal code:

third_party/openconfig/bootz/server/entitymanager/entitymanager.go
[349]
encrypt the response

Nit: This, and the following log entry, are incorrect. The message is being signed, not encrypted.

[third_party/openconfig/bootz/server/service/service.go]
[36]
Key

Nit: It's a good practice to explicitly label this as a private key (i.e. PrivateKey). This helps prevents accidentally mixing up what you're dealing with.

See, for example, google3/third_party/go/gc/src/crypto/tls/common.go;l=1408;ws=codereview%2F678366780;rcl=34

@melzhan melzhan self-assigned this Oct 10, 2023
@melzhan melzhan closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant