Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate protos #105

Closed
gmacf opened this issue Dec 4, 2023 · 2 comments
Closed

De-duplicate protos #105

gmacf opened this issue Dec 4, 2023 · 2 comments
Assignees
@gmacf

Comments

@gmacf
Copy link
Contributor

gmacf commented Dec 4, 2023

We currently have bootz.proto and entity.proto. The former is used for the gRPC API while the latter is mainly used for testing.

entity.proto is mostly a copy of bootz.proto and there's a lot of unfortunate duplication. We should deduplicate this and have bootz.proto as the main one.
@gmacf gmacf self-assigned this Dec 4, 2023
@gmacf
Copy link
Contributor Author

gmacf commented Dec 4, 2023 •
edited
Loading

@mojiiba If you're okay with this change, I'm happy to do it and will send a PR to you.

@mojiiba
Copy link
Contributor

mojiiba commented Dec 4, 2023

Yes, I agree. Please go ahead with the change and let me know if If you need help.
Juts one request: We need to change the fp tests accordingly, so when your pr is ready, let us modify the tests and ensure all testing needs are addressed as part of the PR review.

@gmacf gmacf mentioned this issue Dec 5, 2023
Merged
@gmacf gmacf closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmacf gmacf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmacf @mojiiba