Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAI_MACSEC_SA_ATTR_SALT and SAI_MACSEC_SA_ATTR_MACSEC_SSCI don't have valid only metadata #2128

Open
pony1552 opened this issue Jan 15, 2025 · 3 comments

Comments

@pony1552
Copy link

SAI_MACSEC_SA_ATTR_SALT and SAI_MACSEC_SA_ATTR_MACSEC_SSCI are valid only if SAI_MACSEC_SC_ATTR_MACSEC_CIPHER_SUITE is equal to SAI_MACSEC_CIPHER_SUITE_GCM_AES_XPN_128 or SAI_MACSEC_CIPHER_SUITE_GCM_AES_XPN_256.

But SAI_MACSEC_SA_ATTR_SALT and SAI_MACSEC_SA_ATTR_MACSEC_SSCI don't have validonly metadata.

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 15, 2025

can you add missing validonly tag?

@pony1552
Copy link
Author

I tried to add the tag and it shows error message:

ERROR: validonly attribute SAI_MACSEC_SA_ATTR_SALT has condition from different object SAI_MACSEC_SC_ATTR_MACSEC_CIPHER_SUITE

It seems that validonly tag works for conditions from the same object type.

@kcudnik
Copy link
Collaborator

kcudnik commented Jan 15, 2025

yes, corss object conditions are not supported, if you need to clarify that, please add that condition in description of the attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants