Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move grid_search code to separate repo #78

Open
JamieTaylor-TUOS opened this issue Nov 29, 2021 · 2 comments
Open

Move grid_search code to separate repo #78

JamieTaylor-TUOS opened this issue Nov 29, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@JamieTaylor-TUOS
Copy link
Collaborator

Move the code in pvoutput/grid_search.py to a separate repo.

Context

Code in pvoutput/grid_search.py is sufficiently generic to warrant moving to a separate project and making pip installable.
This would simplify the pvoutput repo somewhat.

Possible Implementation

Move to separate repo (either SheffieldSolar or openclimatefix) and make pip installable.
Add new lib to requirements.txt and setup.py

@JamieTaylor-TUOS
Copy link
Collaborator Author

See also #79

@peterdudfield
Copy link
Contributor

It certain is useful to have it within this repo.
But I can also understand that this code, might be useful independently of 'PVoutput' - probably.

Im happy to make a repo and move it over there, what do you think @JamieTaylor-TUOS ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants