driver-sync: instrument with OpenCensus #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
force-pushed
the
instrument-with-opencensus
branch
3 times, most recently
from
da8a03e to
c439709
Compare
odeke-em
force-pushed
the
instrument-with-opencensus
branch
4 times, most recently
from
a8ea645 to
7d4ff9c
Compare
odeke-em
force-pushed
the
instrument-with-opencensus
branch
5 times, most recently
from
6f802f8 to
5ccb005
Compare
driver-{core, sync}/com.mongodb.client.internal: ScopedSpans
Use ScopedSpans to enable proper context propagation
instead of starting and ending spans manually.
Use `com.mongodb.client.internal.<ClassName>` as the
prefix for the trace.
all: more scopedSpan instrumentation with OpenCensus
driver-sync/*/gridfs: Instrument GridFSBucketImpl
Statically initialized tracer per class that uses it
odeke-em
force-pushed
the
instrument-with-opencensus
branch
from
5ccb005 to
fc2946c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress to instrument this driver with OpenCensus.
All tests pass, repro coming up soon too.
driver-sync/com.mongodb.client.internal: ScopedSpans
Use ScopedSpans to enable proper context propagation
instead of starting and ending spans manually.
Thanks to @bogdandrutu for the advice.