Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cadc-storage-adapter-fs: incorrect iterator() and list() output in "comprehensible" StorageAdapter #66

Open
pdowler opened this issue Feb 25, 2020 · 1 comment
Open

cadc-storage-adapter-fs: incorrect iterator() and list() output in "comprehensible" StorageAdapter #66

pdowler opened this issue Feb 25, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@pdowler
Copy link
Member

pdowler commented Feb 25, 2020

The StorageLocation.storageBucket value is not assigned, resulting in an incorrect ordering of StorageMetadata objects. This issue was exposed by the now complete and consistent implementation of StorageLocation compareTo() and equals().

FileSystemIterator.next() line ~194
FileSystemStorageAdapterTest -- some tests may be disabled so an unrelated PR can be completed
@pdowler pdowler added the bug Something isn't working label Feb 25, 2020
@hjeeves hjeeves mentioned this issue Mar 6, 2020
Merged
@pdowler
Copy link
Member Author

pdowler commented Apr 10, 2020

Fixed in cadc-storage-adapter-fs-0.6 : OpaqueFileSystemIterator implementation

TODO: re-implement the URI mode of FileSystemStorageAdapter so there is also an implementation that creates a comprehensible (thus mountable) filesystem

@pdowler pdowler changed the title cadc-storage-adapter-fs: incorrect iterator() and list() output cadc-storage-adapter-fs: incorrect iterator() and list() output in "comprehensible" StorageAdapter Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pdowler