Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NaN for un-set threshold #3

Open
williamspatrick opened this issue Nov 5, 2020 · 0 comments
Open

use NaN for un-set threshold #3

williamspatrick opened this issue Nov 5, 2020 · 0 comments

Comments

@williamspatrick
Copy link
Member

This commit in phosphor-dbus-interfaces defined an un-set threshold to be required to be NaN instead of 0. This allows thresholds to have zero values.

openbmc/phosphor-dbus-interfaces@2c33a89

As best I can tell, this is the code in phosphor-nvme that determines the threshold values used:
https://github.com/openbmc/phosphor-nvme/blob/master/nvme_manager.cpp#L400

This code is still using integers (uint8_t??) instead of double, so I don't see a feasible way to update this for you. Can someone provide suggestions (or make the update) to take care of the changes required by the above phosphor-dbus-interfaces commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant