Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect byte value for stop byte check in wifi driver causes critical bug for sample parser #2

Open
rivasd opened this issue Aug 1, 2019 · 0 comments

Comments

@rivasd
Copy link

rivasd commented Aug 1, 2019

in wifi.py line 836 there is a check that the first byte of a wifi sample is ==33. However, the docs clearly state that the shield adds 0xa0 to the start of every packet, which is not 33 but rather 160 when translated to int. This critical bug causes all packets to be read as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant