Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twitter cards (EL-225) #239

Open
oajirabot opened this issue Dec 29, 2013 · 0 comments
Open

Add Twitter cards (EL-225) #239

oajirabot opened this issue Dec 29, 2013 · 0 comments

Comments

@oajirabot
Copy link

Will make electionleaflets tweets much nicer


Issue details imported from Jira:

Detail Value
Assignee Matt Joyce
Reporter Matthew Landauer
Created 2013-06-25 15:26:31
Updated 2013-06-28 12:11:00

Imported Jira Comments

Henare Degan - 2013-06-25 15:30:11

Great idea! cc/Matt Joyce

Matt Joyce - 2013-06-26 00:28:45

I am not up to speed on ElectionLeaflets, but I'm guessing images are tweeted.
So, we'd use the Photo card?
https://dev.twitter.com/docs/cards/types/photo-card

Does not seem a big job. Interested.

Henare Degan - 2013-06-26 01:04:39

OK Matt, my response: https://www.youtube.com/watch?v=u6ALySsPXt0

Matt Joyce - 2013-06-27 00:16:26

funny . Righto, I'll fabricate a dev build.

Henare Degan - 2013-06-27 01:30:38

Cool!

Matt Joyce - 2013-06-27 22:57:11

Wow, I have totally forgotten everything about this project.
Took a few hours to just figure out how stuff happens.

Anyway, here's a tentative commit.
mattjoyce@3d84039
I don't know how to issue a pull request for only this commit, github seems to want to include all the previous commits from three years ago. Seems unwise.

Twitter Cards are difficult to test, as Twitter's card validation cannot access my dev system.

Matt Joyce - 2013-06-28 00:33:46

Oh my I made a totally mess of my fork. Will try again.

Matt Joyce - 2013-06-28 12:11:00

OK, pull request submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant