Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery to new version #205

Open
ogis-miyamura opened this issue Dec 26, 2019 · 1 comment
Open

Upgrade jQuery to new version #205

ogis-miyamura opened this issue Dec 26, 2019 · 1 comment
Assignees
Labels
type:maintenance Code quality improvement

Comments

@ogis-miyamura
Copy link
Contributor

Description

jQuery is an important component that affects XUI and other javascript libraly.
jQuery which OpenAM includes is an old version and does not reflect the latest improvements.

Solution

Upgrade jQuery to 3.4.0 or later for reflect the improvements.

Additional context

jQuery inclusion status

  • Repositories forgerock-ui and openam
    • Build artifacts include jquery v1.11 and jquery v2.1.

Known problem

  • Upgrade to jQuery-3.4.0

    • Cannot login to OpenAM.
  • Upgrade to jQuery-3.3.1

    • Cannot add subject at Authorization -> Policy Sets -> Environments.
    • Cannot add property at Server defaults -> Advanced.
@ogis-miyamura ogis-miyamura added the type:maintenance Code quality improvement label Dec 26, 2019
@tsujiguchitky tsujiguchitky self-assigned this Apr 14, 2020
@tsujiguchitky
Copy link
Contributor

Deferred .then() now works asynchronously in jQuery 3.x. As a result, it seems that the order of XUI processing was broken and problems began to occur.

The upgrade guide says as follows:

Another behavior change required for Promises/A+ compliance is that Deferred .then() callbacks 
are always called asynchronously.
Previously, if a .then() callback was added to a Deferred that was already resolved or rejected, 
the callback would run immediately and synchronously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance Code quality improvement
Projects
None yet
Development

No branches or pull requests

2 participants