Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert price to decimal #217

Open
nickevansuk opened this issue Aug 26, 2021 · 0 comments
Open

Revert price to decimal #217

nickevansuk opened this issue Aug 26, 2021 · 0 comments
Labels
CR3 Issues relating to CR3

Comments

@nickevansuk
Copy link
Contributor

In line with the discussion here, the below text should be reverted to instead only allow schema:Number as the value of price (not Float, as this erroneously infers floating point representation).

Note that representing price as a Float leads to the possibility of software rounding errors; accordingly use of Text is recommended here.

All implementers and the tooling are currently using numeric representation, and no issues have so far been reported.

@nickevansuk nickevansuk added the CR3 Issues relating to CR3 label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR3 Issues relating to CR3
Projects
None yet
Development

No branches or pull requests

1 participant