Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Raw data - handle HTTP errors #21

Open
odscjames opened this issue Jun 23, 2020 · 3 comments
Open

Download Raw data - handle HTTP errors #21

odscjames opened this issue Jun 23, 2020 · 3 comments
Assignees

Comments

@odscjames
Copy link
Collaborator

From #18 (comment)

A feed page returns a status of anything other than a 200, 429, or 503 - feed is in an inconsistent state, and is displaying symptoms of an error that should be fixed. Suggest harvesting is restarted from the beginning of the feed the following day, when the errors may have been resolved. If this happens ideally an error would be shown on the status page saying e.g. "Harvesting halted at {pageUrl}, which returned status code {statusCode}".

@odscjames odscjames self-assigned this Jun 25, 2020
@odscjames
Copy link
Collaborator Author

odscjames commented Jun 25, 2020

See #40 . That will log the error. Next time we scrape we will try again.

But is there any reason you say "from the beginning of the feed "? Normally we always try and resume a scrape from where we left off.

@nickevansuk
Copy link
Contributor

If the feed is returning something other than 200, 429, or 503 there are a number of things that could have happened to it (e.g. software reinstallation) - best to start from the beginning to ensure the feed is represented accurately, as previously harvested records are likely irrelevant

@robredpath
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants