Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Container for Development #82

Open
JulianHn opened this issue Sep 24, 2024 · 1 comment
Open

Docker Container for Development #82

JulianHn opened this issue Sep 24, 2024 · 1 comment

Comments

@JulianHn
Copy link

Hey Bene,

while trying to make the Docker Container Work in non-SSL mode, I ran into some trouble using the Docker Containers to actually develop on, as the container build directly depends on the <> GitHub Repo.
I think one of the main benefits of Docker is to have a reproducible production environment, which right now is not really possible.

I would like to discuss changing the Dockerfile to depend on the Repository itself, instead of GitHub. This would mean moving the Dockerfile to the toplevel, so we can use the whole repo as build context and then pip installing from the local repo, not the GitHub Repo.

How does that sound to you?

@beniroquai
Copy link
Collaborator

I'd say that's smart. nothing against it. All auxilary files in the folders docker/* can potentially be (re)moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants