Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas version 0.14.0 is currently not compatible with the code #35

Open
emprice opened this issue Jun 25, 2014 · 4 comments
Open

Pandas version 0.14.0 is currently not compatible with the code #35

emprice opened this issue Jun 25, 2014 · 4 comments

Comments

@emprice
Copy link
Contributor

emprice commented Jun 25, 2014

No description provided.

@zonca
Copy link
Contributor

zonca commented Jun 26, 2014

can you paste the error?

@zonca
Copy link
Contributor

zonca commented Jun 26, 2014

tested on my machine with pandas 0.14.0 and it works fine. Not sure what could be the problem. Please reopen the issue with more details.

@zonca zonca closed this as completed Jun 26, 2014
@emprice
Copy link
Contributor Author

emprice commented Jun 27, 2014

@zonca Take a look at the output from these two builds on Travis. Note that there are no errors, and Python isn't crashing. The problem is that the output is not consistent between the two, even though the input data is the same. The only change of any significance between these two is that I changed the version of pandas to be 0.13.0 instead of 0.14.0, which can be confirmed by comparing the two commits.

Travis with pandas 0.14.0: https://travis-ci.org/openEXO/cloud-kepler/builds/28409173
Travis with pandas 0.13.0: https://travis-ci.org/openEXO/cloud-kepler/builds/28440080

Both builds "pass" because there is no explicit failure. However, if you look at the output itself, you'll see that every transit event with the higher version of pandas is marked as straddling, and the only way for the code to check for that is if the event is not recovered with the input parameters within tolerance. This also happens every time, which is clearly wrong.

I have demonstrated on at least three machines (the Travis remote environment, my Linux laptop, and my Mac laptop) that this behavior can be reproduced simply by changing the version of pandas.

@emprice emprice reopened this Jun 27, 2014
@zonca
Copy link
Contributor

zonca commented Jul 1, 2014

I see, I've no idea what is wrong, we need to debug the code line by line.
I have no time right now, I want to fix the hadoop run first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants