Merge pull request #162 from xiewenlong1202/4.2.x

Chunbo · web-flow · commit 7a584c3e12c6 · 2019-05-29T00:57:36.000-07:00
remove check for firefox
diff --git a/src/sdk/base/mediastream-factory.js b/src/sdk/base/mediastream-factory.js
@@ -187,13 +187,6 @@ export class MediaStreamFactory {
         mediaConstraints.audio = constraints.audio;
       }
     }
-    if (typeof constraints.audio === 'object' &&
-        constraints.audio.source ===
-            MediaFormatModule.AudioSourceInfo.SCREENCAST) {
-      Logger.warning(
-        'Screen sharing with audio is not supported in Firefox.');
-      mediaConstraints.audio = false;
-    }
     if (typeof constraints.video === 'object') {
       mediaConstraints.video = Object.create({});
       if (typeof constraints.video.frameRate === 'number') {

Original file line number	Diff line number	Diff line change
`@@ -187,13 +187,6 @@ export class MediaStreamFactory {`
`187`	`187`	`mediaConstraints.audio = constraints.audio;`
`188`	`188`	`}`
`189`	`189`	`}`
`190`		`- if (typeof constraints.audio === 'object' &&`
`191`		`- constraints.audio.source ===`
`192`		`- MediaFormatModule.AudioSourceInfo.SCREENCAST) {`
`193`		`- Logger.warning(`
`194`		`- 'Screen sharing with audio is not supported in Firefox.');`
`195`		`- mediaConstraints.audio = false;`
`196`		`- }`
`197`	`190`	`if (typeof constraints.video === 'object') {`
`198`	`191`	`mediaConstraints.video = Object.create({});`
`199`	`192`	`if (typeof constraints.video.frameRate === 'number') {`