-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions on query string redaction #1852
Comments
cc @open-telemetry/semconv-http-approvers |
My understanding is that the values of the keys are to be redacted, not the keys themselves. |
Let me clarify the first question from an example. With percent-encoding, If the url contains the For the second question, if the url contains the |
I see. My opinion on casing would be to be case-insensitive. As for the url-encoded of keys and if their values should be redacted, probably trickier but without giving too much thought I'd say its value should also be redacted. |
my understanding is that query string parameter keys are case-sensitive |
The specifications:
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md
Should the percent-encoded parameter names be ignored?
For example the percent-encoding of
sig
is%73%69%67
. Should%73%69%67
be ignored?Should the parameter names be case-sensitive?
For example, should
x-goog-signature
be ignored?The text was updated successfully, but these errors were encountered: