Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding JVM metric for open file descriptors Semantic Conventions #1838

Open
schmikei opened this issue Jan 28, 2025 · 3 comments
Open
Labels
area:jvm enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage

Comments

@schmikei
Copy link

schmikei commented Jan 28, 2025

Propose new conventions

I'd like to add this metric to the java-contrib project.

Image
  - bean: java.lang:type=OperatingSystem
    mapping:
      OpenFileDescriptorCount:
        metric: jvm.fd.open
        unit: 1
        desc: open file descriptors

Happy to discuss naming conventions on these as well but would like to collect this information!

I believe that this metric would be useful for monitoring resource usage and detecting potential file descriptor leaks and should be recommended metric.

Apologies if there was already discussion on adding this metric I just did not see it in the current list found here: https://opentelemetry.io/docs/specs/semconv/runtime/jvm-metrics/

@schmikei schmikei added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve labels Jan 28, 2025
@trask
Copy link
Member

trask commented Jan 29, 2025

hi @schmikei!

let's watch #1798, and once they decide on a name, we can reuse that same name under jvm.*, similar to how we have jvm.cpu.time reflecting process.cpu.time

@trask
Copy link
Member

trask commented Jan 29, 2025

@schmikei
Copy link
Author

@trask

They can be found here:

https://docs.oracle.com/en/java/javase/17/docs/api/jdk.management/com/sun/management/UnixOperatingSystemMXBean.html

They are unix based only since Windows doesn't use file descriptors on the kernel layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:jvm enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage
Projects
Status: Need triage
Development

No branches or pull requests

3 participants