Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency kafka example with messaging semconv #1824

Closed
geny200 opened this issue Jan 27, 2025 · 4 comments · Fixed by #1836
Closed

Inconsistency kafka example with messaging semconv #1824

geny200 opened this issue Jan 27, 2025 · 4 comments · Fixed by #1836
Assignees
Labels
area:messaging bug Something isn't working

Comments

@geny200
Copy link
Contributor

geny200 commented Jan 27, 2025

Area(s)

area:messaging, docs

What's the problem?

Hi, I found out that the kafka example does not match the described standard in the messaging span kind section: messaging.operation.type doesn't match with message span kind in example.

Describe the solution you'd like

I suggest change span kind in the kafka example in accordance with messaging span kind docs.

@joaopgrassi
Copy link
Member

joaopgrassi commented Jan 27, 2025

Hi @geny200 can you clarify which span kind is not in accordance? Do you mean the "Span poll" one? I think you are right, it should be CLIENT, as the other examples like: https://github.com/dynatrace-oss-contrib/semantic-conventions/blob/main/docs/messaging/messaging-spans.md#batch-publishing-with-create-spans

@joaopgrassi joaopgrassi moved this from Need triage to Core SemConv issues in DRAFT - SemConv Issue Triage Jan 27, 2025
@joaopgrassi joaopgrassi self-assigned this Jan 27, 2025
@joaopgrassi joaopgrassi removed the docs label Jan 27, 2025
@geny200
Copy link
Contributor Author

geny200 commented Jan 27, 2025

I think it should be like this:

Field or Attribute Consumer Span Poll Consumer Span Process Consumer Span Commit T
SpanKind CLIENT CONSUMER CLIENT
messaging.operation.type "receive" "process" "settle"

Because in table operation type - span kind:

Operation type Span kind
receive CLIENT
process CONSUMER
settle CLIENT

@joaopgrassi
Copy link
Member

Right, thanks for reporting. I will send a PR to fix it, unless you want to do it :)

@geny200
Copy link
Contributor Author

geny200 commented Jan 28, 2025

Ok, I'll do it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:messaging bug Something isn't working
Projects
Status: Core SemConv issues
Status: V1 - Stable Semantics
Development

Successfully merging a pull request may close this issue.

2 participants