Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Ensure every docs folder has a README? #1819

Open
chalin opened this issue Jan 25, 2025 · 5 comments
Open

[editorial] Ensure every docs folder has a README? #1819

chalin opened this issue Jan 25, 2025 · 5 comments
Labels
docs editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. help wanted Extra attention is needed tooling Regarding build, workflows, build-tools, ...

Comments

@chalin
Copy link
Contributor

chalin commented Jan 25, 2025

This is the semconv version of:

Some folders are missing README.md files:

$ ls -R $(find docs -type d '!' -exec test -e "{}/README.md" ';' -print)
docs/cli:
cli-spans.md

docs/dns:
dns-metrics.md

docs/graphql:
graphql-spans.md

docs/non-normative/groups:
system

docs/non-normative/groups/system:
design-philosophy.md    use-cases.md

When folders don't have a readme, the pages it contains will appear in the left nav rooted in the closest ancestor with a readme. Are you ok with that? Here are the semconv pages as currently published: https://opentelemetry.io/docs/specs/semconv/

For folders containing more than one file, a README.md should be added that lists the folder content.

For folders containing a single file could simply be renamed to README.md or a README.md can be added. WDYT?

@trask
Copy link
Member

trask commented Jan 31, 2025

I think I like the lack of additional nesting when not needed:

Image

as opposed to URL, which has a mostly empty README, and leads to:

Image

@chalin
Copy link
Contributor Author

chalin commented Jan 31, 2025

Yes, I agree. Though, when there is more than one entry in a folder, it should probably have a README. (That could be checked.)

Might be good to remove the README for the "URL" section?

@trask
Copy link
Member

trask commented Jan 31, 2025

when there is more than one entry in a folder, it should probably have a README

👍

Might be good to remove the README for the "URL" section?

#1860

@joaopgrassi
Copy link
Member

Given the URL page was fixed, do we have still something to do here?

@joaopgrassi joaopgrassi added editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. docs and removed triage:needs-triage labels Feb 5, 2025
@chalin
Copy link
Contributor Author

chalin commented Feb 5, 2025

when there is more than one entry in a folder, it should probably have a README. (That could be checked.)

Add a check remains, either via this issue or another. I'm not sure I'll have time to work on this soon (FYI).

@joaopgrassi joaopgrassi added the help wanted Extra attention is needed label Feb 5, 2025
@joaopgrassi joaopgrassi moved this from Need triage to Backlog in DRAFT - SemConv Issue Triage Feb 5, 2025
@joaopgrassi joaopgrassi added the tooling Regarding build, workflows, build-tools, ... label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. help wanted Extra attention is needed tooling Regarding build, workflows, build-tools, ...
Projects
Development

No branches or pull requests

3 participants