Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page feedback - exporter (delimiters) #4296

Open
sparecycles opened this issue Nov 17, 2024 · 3 comments
Open

Page feedback - exporter (delimiters) #4296

sparecycles opened this issue Nov 17, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor

Comments

@sparecycles
Copy link

sparecycles commented Nov 17, 2024

Suggested improvements for page: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md

The "Specifying headers via environment variables" section mentions semi-colon delimited values:

The OTEL_EXPORTER_OTLP_HEADERS, OTEL_EXPORTER_OTLP_TRACES_HEADERS, OTEL_EXPORTER_OTLP_METRICS_HEADERS, OTEL_EXPORTER_OTLP_LOGS_HEADERS environment variables will contain a list of key value pairs, and these are expected to be represented in a format matching to the W3C Baggage, except that additional semi-colon delimited metadata is not supported, i.e.: key1=value1,key2=value2. All attribute values MUST be considered strings.

but the i.e., example is comma-delimited. So is that an example of what to do or what not to do? (that is the question).

Edited by @svrnm to change the URL from opentelemetry.io to the source file in the repo

@svrnm
Copy link
Member

svrnm commented Nov 18, 2024

thanks for raising this issue @sparecycles! Since that file is sourced from the spec repository I will move your issue there

@svrnm svrnm transferred this issue from open-telemetry/opentelemetry.io Nov 18, 2024
@pellared
Copy link
Member

@sparecycles, please read it another time

these are expected to be represented in a format matching to the W3C Baggage, except that additional semi-colon delimited metadata is not supported

Therefore, it is an example of what to do.

@trask
Copy link
Member

trask commented Nov 19, 2024

I agree it reads a bit confusing, I think a clarification PR would be welcome

@trask trask added the triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor label Nov 19, 2024
sparecycles added a commit to sparecycles/opentelemetry-specification that referenced this issue Dec 1, 2024
sparecycles added a commit to sparecycles/opentelemetry-specification that referenced this issue Dec 1, 2024
sparecycles added a commit to sparecycles/opentelemetry-specification that referenced this issue Dec 1, 2024
@arminru arminru added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
Projects
Status: No status
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants