Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prometheus and OpenMetrics] Handle scheme URL and scope attributes as identifying #4223

Open
pellared opened this issue Sep 24, 2024 · 4 comments
Open

[Prometheus and OpenMetrics] Handle scheme URL and scope attributes as identifying #4223

pellared opened this issue Sep 24, 2024 · 4 comments
Assignees
@dashpole @pellared
Labels
sig-issue A specific SIG should look into this before discussing at the spec spec:metrics Related to the specification/metrics directory triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor

Comments

@pellared
Copy link
Member

pellared commented Sep 24, 2024 •
edited
Loading

I think this needs updates to some of the compatibility docs (at least prometheus). Currently, Prometheus adds scope name and scope version as labels to ensure we don't end up with duplicate timeseries, and we are able to put scope attributes in a separate otel_scope_info metric. With this change, we will need to update this to instead add the scope name, scope version, and scope attributes to all metrics.

TIL schema_url is also identifying, so that is something we will need to handle in Prometheus export and other "non-OTLP" compatibility documents.

Originally posted by @dashpole in #4161 (comment)
@pellared pellared added the spec:metrics Related to the specification/metrics directory label Sep 24, 2024
@pellared
Copy link
Member Author

@dashpole, are you able to take this?

@dashpole
Copy link
Contributor

cc @open-telemetry/wg-prometheus

Yes, I'll take this

@dashpole dashpole self-assigned this Sep 24, 2024
@pellared pellared mentioned this issue Sep 25, 2024
Open
@svrnm svrnm added sig-issue A specific SIG should look into this before discussing at the spec triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor labels Sep 30, 2024
@pellared pellared changed the title [Prometheus] Make instrumentation scope as identifying [Prometheus] Add otel_scheme_url label to otel_scope_info metric Oct 28, 2024
@pellared pellared changed the title [Prometheus] Add otel_scheme_url label to otel_scope_info metric [Prometheus and OpenMetrics] Add otel_scheme_url label to otel_scope_info metric Oct 31, 2024
@pellared pellared changed the title [Prometheus and OpenMetrics] Add otel_scheme_url label to otel_scope_info metric [Prometheus and OpenMetrics] Handle scheme URL and scope attributes as identifying Oct 31, 2024
@pellared
Copy link
Member Author

pellared commented Oct 31, 2024 •
edited
Loading

The idea is to add otel_scope_[attribute] and otel_scheme_url labels to metrics.

I will do my best to help with this issue.

@pellared pellared self-assigned this Oct 31, 2024
This was referenced Nov 4, 2024
Merged
Draft
@pellared
Copy link
Member Author

A prototype in Go: open-telemetry/opentelemetry-go#5947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

@pellared pellared

Labels
sig-issue A specific SIG should look into this before discussing at the spec spec:metrics Related to the specification/metrics directory triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
Projects
🔭 Main Backlog
Status: Spec - Accepted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@svrnm @dashpole @pellared