Replace regex crate with glob crate (#1301)

* remove regex crate

* update cargo.toml

* fix dependency

* add unittest

* add changelog

* order tests

* fix unit test

* do disk cleanup before tests

* fix disk cleanup

* fix disk cleanup

* fix disk cleanup

* fix disk cleanup

* fix disk cleanup

Author: lalitb

.github/workflows/ci.yml

@@ -13,6 +13,12 @@ jobs:
         rust: [stable, beta]
     runs-on: ubuntu-latest
     steps:
+    - name: Free disk space
+      run: |
+        df -h
+        sudo rm -rf /usr/local/lib/android
+        sudo rm -rf /usr/share/dotnet
+        df -h
     - uses: actions/checkout@v1
       with:
         submodules: true

opentelemetry-sdk/CHANGELOG.md

@@ -28,6 +28,8 @@
 - Increase instrument name maximum length from 63 to 255 (#1269)
 - Updated crate documentation and examples.
   [#1256](https://github.com/open-telemetry/opentelemetry-rust/issues/1256)
+- Replace regex with glob (#1301)
+
 
 ### Removed
 

opentelemetry-sdk/Cargo.toml

@@ -22,7 +22,7 @@ once_cell = "1.10"
 ordered-float = "4.0"
 percent-encoding = { version = "2.0", optional = true }
 rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional = true }
-regex = { version = "1.0", optional = true }
+glob = {version = "0.3.1", optional =true}
 serde = { version = "1.0", features = ["derive", "rc"], optional = true }
 serde_json = { version = "1", optional = true }
 thiserror = "1"
@@ -47,7 +47,7 @@ trace = ["opentelemetry/trace", "crossbeam-channel", "rand", "async-trait", "per
 jaeger_remote_sampler = ["trace", "opentelemetry-http", "http", "serde", "serde_json", "url"]
 logs = ["opentelemetry/logs", "crossbeam-channel", "async-trait", "serde_json"]
 logs_level_enabled = ["logs", "opentelemetry/logs_level_enabled"]
-metrics = ["opentelemetry/metrics", "regex", "async-trait"]
+metrics = ["opentelemetry/metrics", "glob", "async-trait"]
 testing = ["opentelemetry/testing", "trace", "metrics", "logs", "rt-async-std", "rt-tokio", "rt-tokio-current-thread", "tokio/macros", "tokio/rt-multi-thread"]
 rt-tokio = ["tokio", "tokio-stream"]
 rt-tokio-current-thread = ["tokio", "tokio-stream"]

opentelemetry-sdk/src/metrics/view.rs

@@ -1,10 +1,9 @@
+use super::instrument::{Instrument, Stream};
+use glob::Pattern;
 use opentelemetry::{
     global,
     metrics::{MetricsError, Result},
 };
-use regex::Regex;
-
-use super::instrument::{Instrument, Stream};
 
 fn empty_view(_inst: &Instrument) -> Option<Stream> {
     None
@@ -119,16 +118,12 @@ pub fn new_view(criteria: Instrument, mask: Stream) -> Result<Box<dyn View>> {
             return Ok(Box::new(empty_view));
         }
 
-        let pattern = criteria
-            .name
-            .trim_start_matches('^')
-            .trim_end_matches('$')
-            .replace('?', ".")
-            .replace('*', ".*");
-        let re =
-            Regex::new(&format!("^{pattern}$")).map_err(|e| MetricsError::Config(e.to_string()))?;
+        let pattern = criteria.name.clone();
+        let glob_pattern =
+            Pattern::new(&pattern).map_err(|e| MetricsError::Config(e.to_string()))?;
+
         Box::new(move |i| {
-            re.is_match(&i.name)
+            glob_pattern.matches(&i.name)
                 && criteria.matches_description(i)
                 && criteria.matches_kind(i)
                 && criteria.matches_unit(i)
@@ -177,3 +172,84 @@ pub fn new_view(criteria: Instrument, mask: Stream) -> Result<Box<dyn View>> {
         }
     }))
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::metrics::Instrument;
+    #[test]
+    fn test_new_view_matching_all() {
+        let criteria = Instrument::new().name("*");
+        let mask = Stream::new();
+
+        let view = new_view(criteria, mask).expect("Expected to create a new view");
+
+        let test_instrument = Instrument::new().name("test_instrument");
+        assert!(
+            view.match_inst(&test_instrument).is_some(),
+            "Expected to match all instruments with * pattern"
+        );
+    }
+
+    #[test]
+    fn test_new_view_exact_match() {
+        let criteria = Instrument::new().name("counter_exact_match");
+        let mask = Stream::new();
+
+        let view = new_view(criteria, mask).expect("Expected to create a new view");
+
+        let matching_instrument = Instrument::new().name("counter_exact_match");
+        assert!(
+            view.match_inst(&matching_instrument).is_some(),
+            "Expected to match instrument with exact name"
+        );
+
+        let non_matching_instrument = Instrument::new().name("counter_non_exact_match");
+        assert!(
+            view.match_inst(&non_matching_instrument).is_none(),
+            "Expected not to match instrument with different name"
+        );
+    }
+
+    #[test]
+    fn test_new_view_with_wildcard_pattern() {
+        let criteria = Instrument::new().name("prefix_*");
+        let mask = Stream::new();
+
+        let view = new_view(criteria, mask).expect("Expected to create a new view");
+
+        let matching_instrument = Instrument::new().name("prefix_counter");
+        assert!(
+            view.match_inst(&matching_instrument).is_some(),
+            "Expected to match instrument with matching prefix"
+        );
+
+        let non_matching_instrument = Instrument::new().name("nonprefix_counter");
+        assert!(
+            view.match_inst(&non_matching_instrument).is_none(),
+            "Expected not to match instrument with different prefix"
+        );
+    }
+
+    #[test]
+    fn test_new_view_wildcard_question_mark() {
+        let criteria = Instrument::new().name("test_?");
+        let mask = Stream::new();
+
+        let view = new_view(criteria, mask).expect("Expected to create a new view");
+
+        // Instrument name that should match the pattern "test_?".
+        let matching_instrument = Instrument::new().name("test_1");
+        assert!(
+            view.match_inst(&matching_instrument).is_some(),
+            "Expected to match instrument with test_? pattern"
+        );
+
+        // Instrument name that should not match the pattern "test_?".
+        let non_matching_instrument = Instrument::new().name("test_12");
+        assert!(
+            view.match_inst(&non_matching_instrument).is_none(),
+            "Expected not to match instrument with test_? pattern"
+        );
+    }
+}