Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aiohttp-server instrumentation does not follow semantic conventions about http span name #3222

Open
nesb1 opened this issue Jan 30, 2025 · 1 comment

Comments

@nesb1
Copy link
Contributor

nesb1 commented Jan 30, 2025

Describe your environment

Problem not related to the environment

What happened?

I found that aiohttp-server do not follow convention about http span name.

There are two things that need to be fixed:

  1. Show only http method in span name by a default.
  2. Create an option to show url in a span name, but it must be disabled by default.

Steps to Reproduce

Just make request to app with aiohttp-server-instrumentation

Expected Result

Spans created by this instrumentation follow semantic conventions for http spans

Actual Result

Spans created by this instrumentation do not follow semantic conventions for http spans

Additional context

No response

Would you like to implement a fix?

Yes

@nesb1 nesb1 added the bug Something isn't working label Jan 30, 2025
@emdneto
Copy link
Member

emdneto commented Jan 30, 2025

Right. Because the instrumentation was created using an unstable version of semantic convention. To change this, you should also adapt all the attributes to be compliant with the stable semantic convention version or implement the semantic convention opt-in feature for HTTP Instrumentation, see #2453.

@emdneto emdneto added feature-request and removed bug Something isn't working labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants