fix(sdk-metrics) Don't Export from PeriodicExportingMetricReader with No Metrics #5288
+93
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5288 +/- ##
=======================================
Coverage 94.56% 94.56%
=======================================
Files 322 322
Lines 8132 8134 +2
Branches 1715 1716 +1
=======================================
+ Hits 7690 7692 +2
Misses 442 442
|
maryliag
approved these changes
Dec 20, 2024
hectorhdzg
reviewed
Dec 20, 2024
Co-authored-by: Hector Hernandez <[email protected]>
pichlermarc
approved these changes
Jan 7, 2025
| throw new Error( | ||
| `PeriodicExportingMetricReader: metrics export failed (error ${result.error})` | ||
| ); | ||
| if (resourceMetrics.scopeMetrics.length > 0) { |
There was a problem hiding this comment.
nit (feel free to ignore): I like having guard clauses that just return - reduces nesting and it also makes it easier to see if we hit the branch in in the coverage report.
There was a problem hiding this comment.
Implemented, thanks for the suggestion!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pichlermarc
reviewed
Jan 10, 2025
packages/sdk-metrics/test/export/PeriodicExportingMetricReader.test.ts
Outdated
Show resolved
Hide resolved
….test.ts Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We should not attempt to export without metrics to export from the
PeriodiicExportingMetricReader.Fixes #5234
Short description of the changes
Adds a check to ensure that scope metrics are populated and updates related tests.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: