docs(graphql-instrumentation): add documentation for ignoreResolveSpans #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogotorres97
approved these changes
Jan 25, 2024
|
For reference the |
trentm
requested changes
Jan 25, 2024
|
Thanks for following up on #1858 with this PR! Just a couple of nits, otherwise LGTM. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 145 145
Lines 7431 7431
Branches 1489 1489
=======================================
Hits 6800 6800
Misses 631 631 |
Co-authored-by: Trent Mick <[email protected]>
|
@trentm suggestions accepted |
trentm
approved these changes
Jan 25, 2024
seemk
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes