Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on function names for instrumentation #2522

Open
drewcorlin1 opened this issue Nov 9, 2024 · 0 comments
Open

Do not depend on function names for instrumentation #2522

drewcorlin1 opened this issue Nov 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working pkg:instrumentation-redis-4 priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization

Comments

@drewcorlin1
Copy link
Contributor

What version of OpenTelemetry are you using?

What version of Node are you using?

20

What did you do?

I am working on an esbuild plugin version of this library and noticed that the @opentelemetry/instrumentation-redis-4 package relies on the function name of classes. This can break when code is bundled due to bundlers renaming symbols.

It's worth noting that with esbuild there is a workaround, to use keepNames, but this a lot of diving into the instrumentation source code to discover the cause of the issue.

I know that feature is not merged, but based on the comments there seems to be demand for it, so relying on function names will be potentially problematic for any bundler-based instrumentations of this library.

@drewcorlin1 drewcorlin1 added the bug Something isn't working label Nov 9, 2024
@dyladan dyladan self-assigned this Nov 20, 2024
@pichlermarc pichlermarc added the priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:instrumentation-redis-4 priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization
Projects
None yet
Development

No branches or pull requests

3 participants