Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] switch to dependabot #1827

Open
pichlermarc opened this issue Nov 27, 2023 · 2 comments
Open

[internal] switch to dependabot #1827

pichlermarc opened this issue Nov 27, 2023 · 2 comments
Labels
internal up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@pichlermarc
Copy link
Member

See #1806. Renovate bot does not handle package-lock.json updates correctly at the moment. It is unclear if this is due to misconfiguration or a bug in renovate.

Since the diff in package-lock.json has significant impact on the developer experience, we should switch to dependabot as it handles updates package-lock.json as we expect it.

Part of this issue is

  • translating the current renovate config to renovate (with regards to grouping, ignored packages - improvements welcome 🙂 )
  • disabling renovate bot
    • removing the config in the repository
    • reach out to a Maintainer to uninstall the app from the repository
@pichlermarc pichlermarc added internal up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 27, 2023
@trentm
Copy link
Contributor

trentm commented Mar 7, 2024

I wonder, now that #1917 is basically sorted out, if renovate will suffice -- as long as we configure it to skip @opentelemetry/* packages in its updates.

My personal experience is with dependabot, but it definitely has rough edges. Given the two OTel JS repos have been using renovate successfully for a while, I'd be inclined to give renovate another shot. What do you think?

@pichlermarc
Copy link
Member Author

Yes renovate might suffice 👍 I think we can keep using it, but we'll need to have an eye out for any irregularities in the package-lock.json. I'm still open to giving dependabot a shot if we can roughly replicate the grouping we currently have with renovate.

With renovate I'm mainly worried about the behavior we see in renovatebot/renovate#25847. I can still see the same happening on the reproducer I linked. But since the release PR workflow adds a commit to sync package-lock.json it would bring the file back to a consistent state. So that's just a minor annoyance and I think it will likely be fine. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants