-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP GRPC exporters don't respect domain NO_PROXY settings due to grpc bug #5976
Comments
Hello @MrAlias! I would like to contribute the fix for this issue. |
Short term workaround: grpc/grpc-go#7556 (comment) We plan to hold off on this until the next release of grpc: https://github.com/grpc/grpc-go/milestone/67 If it is not resolved in that release we will re-evaluate applying a more permanent fix here. |
sure @MrAlias |
Note: the collector has already switched back to using the |
Yep I made that change since the collector sanitizes the endpoint so we can't use the passthrough resolver |
grpc 1.69.0 release notes mention this will be addressed in 1.70.0. |
Description
Brought up this issue in the collector repo, realized it should likely be applied here as well.
There's a bug in grpc-go (here and here) related to the way NewClient does hostname resolution where now the host is resolved before the ProxyFromEnvironment function is called, due to this domain based no_proxy settings are not applied as the comparison is done only against the ip. localhost is not affected.
The grpc team is working on a fix but it seems like until that's in place we might want to revert to DialContext instead of NewClient.
Environment
Steps To Reproduce
Set HTTP/S_PROXY
Init OTLP GRPC client with target endpoint
Include endpoint sub-domain in NO_PROXY
Expected behavior
HTTP/S_PROXY setting should still be applied
The text was updated successfully, but these errors were encountered: