From 9bed5139a3ec46b3d4650e3f3feffa82c0b82be0 Mon Sep 17 00:00:00 2001 From: Alex Boten <223565+codeboten@users.noreply.github.com> Date: Thu, 3 Oct 2024 10:14:16 -0700 Subject: [PATCH] chore: removing unnecessary comments The comment at the top is no longer true, the one at the bottom is no longer applicable as it was decided to wait to support JSON format parsing. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> --- config/config.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/config/config.go b/config/config.go index 052052cb658..16193946887 100644 --- a/config/config.go +++ b/config/config.go @@ -63,8 +63,6 @@ func (s *SDK) Shutdown(ctx context.Context) error { } // NewSDK creates SDK providers based on the configuration model. -// -// Caution: The implementation only returns noop providers. func NewSDK(opts ...ConfigurationOption) (SDK, error) { o := configOptions{} for _, opt := range opts { @@ -129,9 +127,6 @@ func WithOpenTelemetryConfiguration(cfg OpenTelemetryConfiguration) Configuratio }) } -// TODO: implement parsing functionality: -// - https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4412 - // ParseYAML parses a YAML configuration file into an OpenTelemetryConfiguration. func ParseYAML(file []byte) (*OpenTelemetryConfiguration, error) { var cfg OpenTelemetryConfiguration