From 89234c1452353fe43e4ea9bd57f0fb70ba32f069 Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 11:26:35 -0800 Subject: [PATCH 1/8] Asp.NetCore readme --- .../README.md | 51 ++++++++++++++----- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index 38269610e4..051150788d 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -10,17 +10,15 @@ collect metrics and traces about incoming web requests. This instrumentation also collects traces from incoming gRPC requests using [Grpc.AspNetCore](https://www.nuget.org/packages/Grpc.AspNetCore). -**Note: This component is based on the OpenTelemetry semantic conventions for +**Note: This component is based on the +[v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0) of +http semantic conventions for [metrics](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md) and [traces](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md). -These conventions are -[Experimental](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/document-status.md), -and hence, this package is a [pre-release](../../VERSIONING.md#pre-releases). -Until a [stable -version](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/telemetry-stability.md) -is released, there can be breaking changes. You can track the progress from -[milestones](https://github.com/open-telemetry/opentelemetry-dotnet/milestone/23).** + +Instrumentation support for gRPC server requests is supported via an +[experimental](#experimental-support-for-grpc-requests) feature flag. ## Steps to enable OpenTelemetry.Instrumentation.AspNetCore @@ -31,7 +29,7 @@ Add a reference to the package. Also, add any other instrumentations & exporters you will need. ```shell -dotnet add package --prerelease OpenTelemetry.Instrumentation.AspNetCore +dotnet add package OpenTelemetry.Instrumentation.AspNetCore ``` ### Step 2: Enable ASP.NET Core Instrumentation at application startup @@ -138,6 +136,8 @@ newer versions. ## Advanced configuration +### Tracing + This instrumentation can be configured to change the default behavior by using `AspNetCoreTraceInstrumentationOptions`, which allows adding [`Filter`](#filter), [`Enrich`](#enrich) as explained below. @@ -166,7 +166,7 @@ services.AddOpenTelemetry() .AddConsoleExporter()); ``` -### Filter +#### Filter This instrumentation by default collects all the incoming http requests. It allows filtering of requests by using the `Filter` function in @@ -194,7 +194,7 @@ instrumentation. OpenTelemetry has a concept of a [Sampler](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#sampling), and the `Filter` option does the filtering *after* the Sampler is invoked. -### Enrich +#### Enrich This instrumentation library provides `EnrichWithHttpRequest`, `EnrichWithHttpResponse` and `EnrichWithException` options that can be used to @@ -231,13 +231,13 @@ is the general extensibility point to add additional properties to any activity. The `Enrich` option is specific to this instrumentation, and is provided to get access to `HttpRequest` and `HttpResponse`. -### RecordException +#### RecordException This instrumentation automatically sets Activity Status to Error if an unhandled exception is thrown. Additionally, `RecordException` feature may be turned on, to store the exception to the Activity itself as ActivityEvent. -## Activity Duration and http.server.request.duration metric calculation +## Activity duration and http.server.request.duration metric calculation `Activity.Duration` and `http.server.request.duration` values represents the time used to handle an inbound HTTP request as measured at the hosting layer of @@ -254,6 +254,31 @@ The time ends when: * All response data has been sent. * The context data structures for the request are being disposed. +## Experimental support for gRPC requests + +gRPC instrumentation can be enabled by setting +`OTEL_DOTNET_EXPERIMENTAL_ASPNETCORE_ENABLE_GRPC_INSTRUMENTATION` flag to +`True`. The flag can be set as an environment variable or via IConfiguration as +shown below. + +```csharp +var appBuilder = WebApplication.CreateBuilder(args); + +appBuilder.Configuration.AddInMemoryCollection( + new Dictionary + { + ["OTEL_DOTNET_EXPERIMENTAL_ASPNETCORE_ENABLE_GRPC_INSTRUMENTATION"] = "true", + }); + +appBuilder.Services.AddOpenTelemetry() + .WithTracing(tracing => tracing + .AddAspNetCoreInstrumentation()); +``` + + Semantic conventions for RPC are still + [experimental](https://github.com/open-telemetry/semantic-conventions/tree/main/docs/rpc) + and hence the instrumentation only offers it as an experimental feature. + ## Troubleshooting This component uses an From c0daf2e05b1b96f787b8db24df06ff59b2199dcd Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 11:30:12 -0800 Subject: [PATCH 2/8] add httpclient readme --- .../README.md | 4 +-- .../README.md | 36 +++++++++---------- 2 files changed, 18 insertions(+), 22 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index 051150788d..e717060585 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -13,9 +13,9 @@ also collects traces from incoming gRPC requests using **Note: This component is based on the [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0) of http semantic conventions for -[metrics](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md) +[metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) and -[traces](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md). +[traces](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md). Instrumentation support for gRPC server requests is supported via an [experimental](#experimental-support-for-grpc-requests) feature flag. diff --git a/src/OpenTelemetry.Instrumentation.Http/README.md b/src/OpenTelemetry.Instrumentation.Http/README.md index 4eb4e2adf7..7878c2836c 100644 --- a/src/OpenTelemetry.Instrumentation.Http/README.md +++ b/src/OpenTelemetry.Instrumentation.Http/README.md @@ -11,18 +11,12 @@ and [System.Net.HttpWebRequest](https://docs.microsoft.com/dotnet/api/system.net.httpwebrequest) and collects metrics and traces about outgoing HTTP requests. -**Note: This component is based on the OpenTelemetry semantic conventions for -[metrics](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md) +**Note: This component is based on the +[v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0) of +http semantic conventions for +[metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) and -[traces](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md). -These conventions are -[Experimental](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/document-status.md), -and hence, this package is a [pre-release](../../VERSIONING.md#pre-releases). -Until a [stable -version](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/telemetry-stability.md) -is released, there can be [breaking changes](./CHANGELOG.md). You can track the -progress from -[milestones](https://github.com/open-telemetry/opentelemetry-dotnet/milestone/23).** +[traces](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md). ## Steps to enable OpenTelemetry.Instrumentation.Http @@ -33,7 +27,7 @@ Add a reference to the package. Also, add any other instrumentations & exporters you will need. ```shell -dotnet add package --prerelease OpenTelemetry.Instrumentation.Http +dotnet add package OpenTelemetry.Instrumentation.Http ``` ### Step 2: Enable HTTP Instrumentation at application startup @@ -147,6 +141,8 @@ newer versions. ## Advanced configuration +### Tracing + This instrumentation can be configured to change the default behavior by using `HttpClientTraceInstrumentationOptions`. It is important to note that there are differences between .NET Framework and newer .NET/.NET Core runtimes which @@ -155,9 +151,9 @@ govern what options are used. On .NET Framework, `HttpClient` uses the `HttpClient` API. As such, depending on the runtime, only one half of the "filter" & "enrich" options are used. -### .NET & .NET Core +#### .NET & .NET Core -#### Filter HttpClient API +##### Filter HttpClient API This instrumentation by default collects all the outgoing HTTP requests. It allows filtering of requests by using the `FilterHttpRequestMessage` function @@ -189,7 +185,7 @@ to this instrumentation. OpenTelemetry has a concept of a and the `FilterHttpRequestMessage` option does the filtering *after* the Sampler is invoked. -#### Enrich HttpClient API +##### Enrich HttpClient API This instrumentation library provides options that can be used to enrich the activity with additional information. These actions are called @@ -228,9 +224,9 @@ var tracerProvider = Sdk.CreateTracerProviderBuilder() .Build(); ``` -### .NET Framework +#### .NET Framework -#### Filter HttpWebRequest API +##### Filter HttpWebRequest API This instrumentation by default collects all the outgoing HTTP requests. It allows filtering of requests by using the `FilterHttpWebRequest` function @@ -262,7 +258,7 @@ this instrumentation. OpenTelemetry has a concept of a and the `FilterHttpWebRequest` option does the filtering *after* the Sampler is invoked. -#### Enrich HttpWebRequest API +##### Enrich HttpWebRequest API This instrumentation library provides options that can be used to enrich the activity with additional information. These actions are called @@ -306,13 +302,13 @@ general extensibility point to add additional properties to any activity. The `Enrich` option is specific to this instrumentation, and is provided to get access to raw request, response, and exception objects. -### RecordException +#### RecordException This instrumentation automatically sets Activity Status to Error if the Http StatusCode is >= 400. Additionally, `RecordException` feature may be turned on, to store the exception to the Activity itself as ActivityEvent. -## Activity Duration and http.client.request.duration metric calculation +## Activity duration and http.client.request.duration metric calculation `Activity.Duration` and `http.client.request.duration` values represents the time the underlying client handler takes to complete the request. Completing the From 98f9c177cc73155a86fdb20b77606461be0e8321 Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 13:56:13 -0800 Subject: [PATCH 3/8] add attributes list --- .../README.md | 41 ++++++++++++++++--- .../README.md | 38 ++++++++++++++--- 2 files changed, 69 insertions(+), 10 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index e717060585..fc9547382b 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -11,11 +11,42 @@ also collects traces from incoming gRPC requests using [Grpc.AspNetCore](https://www.nuget.org/packages/Grpc.AspNetCore). **Note: This component is based on the -[v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0) of -http semantic conventions for -[metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) -and -[traces](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md). +[v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) +of http semantic conventions. + +Following list of attributes are added by default on activity. See +[http-spans](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md) +for more details about each individual attribute: + +* `error.type` +* `http.request.method` +* `http.request.method_original` +* `http.response.status_code` +* `http.route` +* `network.protocol.version` +* `user_agent.original` +* `server.address` +* `server.port` +* `url.path` +* `url.query` +* `url.scheme` + +[Enrich Api](#enrich) can be used if any additional attributes are +required on activity. + +Follwing list of attributes are added by default on +`http.server.request.duration` metric. See +[http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) +for more details about each individual attribute. `.NET8.0` and above supports +additional metrics, see [list of metrics produced](list-of-metrics-produced) for +more details. + +* `error.type` +* `http.response.status_code` +* `http.request.method` +* `http.route` +* `network.protocol.version` +* `url.scheme` Instrumentation support for gRPC server requests is supported via an [experimental](#experimental-support-for-grpc-requests) feature flag. diff --git a/src/OpenTelemetry.Instrumentation.Http/README.md b/src/OpenTelemetry.Instrumentation.Http/README.md index 7878c2836c..d17190d290 100644 --- a/src/OpenTelemetry.Instrumentation.Http/README.md +++ b/src/OpenTelemetry.Instrumentation.Http/README.md @@ -12,11 +12,39 @@ and and collects metrics and traces about outgoing HTTP requests. **Note: This component is based on the -[v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0) of -http semantic conventions for -[metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) -and -[traces](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md). +[v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) +of http semantic conventions. + +Following list of attributes are added by default on activity. See +[http-spans](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md) +for more details about each individual attribute: + +* `error.type` +* `http.request.method` +* `http.request.method_original` +* `http.response.status_code` +* `network.protocol.version` +* `server.address` +* `server.port` +* `url.full` + +[Enrich Api](#enrich-httpclient-api) can be used if any additional attributes are +required on activity. + +Follwing list of attributes are added by default on +`http.client.request.duration` metric. See +[http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) +for more details about each individual attribute. `.NET8.0` and above supports +additional metrics, see [list of metrics produced](list-of-metrics-produced) for +more details. + +* `error.type` +* `http.request.method` +* `http.response.status_code` +* `network.protocol.version` +* `server.address` +* `server.port` +* `url.scheme` ## Steps to enable OpenTelemetry.Instrumentation.Http From 882fd9f53108f0f5d10772816cbca740a5418940 Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 14:06:04 -0800 Subject: [PATCH 4/8] move experimental note --- src/OpenTelemetry.Instrumentation.AspNetCore/README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index fc9547382b..92285be2ec 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -9,6 +9,8 @@ which instruments [ASP.NET Core](https://docs.microsoft.com/aspnet/core) and collect metrics and traces about incoming web requests. This instrumentation also collects traces from incoming gRPC requests using [Grpc.AspNetCore](https://www.nuget.org/packages/Grpc.AspNetCore). +Instrumentation support for gRPC server requests is supported via an +[experimental](#experimental-support-for-grpc-requests) feature flag. **Note: This component is based on the [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) @@ -48,9 +50,6 @@ more details. * `network.protocol.version` * `url.scheme` -Instrumentation support for gRPC server requests is supported via an -[experimental](#experimental-support-for-grpc-requests) feature flag. - ## Steps to enable OpenTelemetry.Instrumentation.AspNetCore ### Step 1: Install Package From a538cad1262cab4af16743d4f30953aa49f56ed6 Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 14:10:35 -0800 Subject: [PATCH 5/8] move list --- .../README.md | 71 ++++++++++--------- .../README.md | 65 ++++++++--------- 2 files changed, 69 insertions(+), 67 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index 92285be2ec..1948fc9e81 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -14,41 +14,8 @@ Instrumentation support for gRPC server requests is supported via an **Note: This component is based on the [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) -of http semantic conventions. - -Following list of attributes are added by default on activity. See -[http-spans](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md) -for more details about each individual attribute: - -* `error.type` -* `http.request.method` -* `http.request.method_original` -* `http.response.status_code` -* `http.route` -* `network.protocol.version` -* `user_agent.original` -* `server.address` -* `server.port` -* `url.path` -* `url.query` -* `url.scheme` - -[Enrich Api](#enrich) can be used if any additional attributes are -required on activity. - -Follwing list of attributes are added by default on -`http.server.request.duration` metric. See -[http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) -for more details about each individual attribute. `.NET8.0` and above supports -additional metrics, see [list of metrics produced](list-of-metrics-produced) for -more details. - -* `error.type` -* `http.response.status_code` -* `http.request.method` -* `http.route` -* `network.protocol.version` -* `url.scheme` +of http semantic conventions. For details on the default set of attributes that +are added, checkout [Traces](#traces) and [Metrics](#metrics) sections below. ## Steps to enable OpenTelemetry.Instrumentation.AspNetCore @@ -94,6 +61,26 @@ public void ConfigureServices(IServiceCollection services) } ``` +Following list of attributes are added by default on activity. See +[http-spans](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md) +for more details about each individual attribute: + +* `error.type` +* `http.request.method` +* `http.request.method_original` +* `http.response.status_code` +* `http.route` +* `network.protocol.version` +* `user_agent.original` +* `server.address` +* `server.port` +* `url.path` +* `url.query` +* `url.scheme` + +[Enrich Api](#enrich) can be used if any additional attributes are +required on activity. + #### Metrics The following example demonstrates adding ASP.NET Core instrumentation with the @@ -116,6 +103,20 @@ public void ConfigureServices(IServiceCollection services) } ``` +Following list of attributes are added by default on +`http.server.request.duration` metric. See +[http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) +for more details about each individual attribute. `.NET8.0` and above supports +additional metrics, see [list of metrics produced](list-of-metrics-produced) for +more details. + +* `error.type` +* `http.response.status_code` +* `http.request.method` +* `http.route` +* `network.protocol.version` +* `url.scheme` + #### List of metrics produced When the application targets `.NET6.0` or `.NET7.0`, the instrumentation emits diff --git a/src/OpenTelemetry.Instrumentation.Http/README.md b/src/OpenTelemetry.Instrumentation.Http/README.md index d17190d290..ae935dbc42 100644 --- a/src/OpenTelemetry.Instrumentation.Http/README.md +++ b/src/OpenTelemetry.Instrumentation.Http/README.md @@ -13,38 +13,8 @@ and collects metrics and traces about outgoing HTTP requests. **Note: This component is based on the [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) -of http semantic conventions. - -Following list of attributes are added by default on activity. See -[http-spans](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md) -for more details about each individual attribute: - -* `error.type` -* `http.request.method` -* `http.request.method_original` -* `http.response.status_code` -* `network.protocol.version` -* `server.address` -* `server.port` -* `url.full` - -[Enrich Api](#enrich-httpclient-api) can be used if any additional attributes are -required on activity. - -Follwing list of attributes are added by default on -`http.client.request.duration` metric. See -[http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) -for more details about each individual attribute. `.NET8.0` and above supports -additional metrics, see [list of metrics produced](list-of-metrics-produced) for -more details. - -* `error.type` -* `http.request.method` -* `http.response.status_code` -* `network.protocol.version` -* `server.address` -* `server.port` -* `url.scheme` +of http semantic conventions. For details on the default set of attributes that +are added, checkout [Traces](#traces) and [Metrics](#metrics) sections below. ## Steps to enable OpenTelemetry.Instrumentation.Http @@ -87,6 +57,22 @@ public class Program } ``` +Following list of attributes are added by default on activity. See +[http-spans](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-spans.md) +for more details about each individual attribute: + +* `error.type` +* `http.request.method` +* `http.request.method_original` +* `http.response.status_code` +* `network.protocol.version` +* `server.address` +* `server.port` +* `url.full` + +[Enrich Api](#enrich-httpclient-api) can be used if any additional attributes are +required on activity. + #### Metrics The following example demonstrates adding `HttpClient` instrumentation with the @@ -119,6 +105,21 @@ Refer to this [example](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Instrumentation.AspNet/README.md) to see how to enable this instrumentation in an ASP.NET application. +Following list of attributes are added by default on +`http.client.request.duration` metric. See +[http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) +for more details about each individual attribute. `.NET8.0` and above supports +additional metrics, see [list of metrics produced](list-of-metrics-produced) for +more details. + +* `error.type` +* `http.request.method` +* `http.response.status_code` +* `network.protocol.version` +* `server.address` +* `server.port` +* `url.scheme` + #### List of metrics produced When the application targets `NETFRAMEWORK`, `.NET6.0` or `.NET7.0`, the From 0fe6be6488a2f36b19a4c89d4fd37ce278ccfdb3 Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 14:11:48 -0800 Subject: [PATCH 6/8] nit --- src/OpenTelemetry.Instrumentation.AspNetCore/README.md | 2 +- src/OpenTelemetry.Instrumentation.Http/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index 1948fc9e81..1a4dfebd12 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -12,7 +12,7 @@ also collects traces from incoming gRPC requests using Instrumentation support for gRPC server requests is supported via an [experimental](#experimental-support-for-grpc-requests) feature flag. -**Note: This component is based on the +This component is based on the [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) of http semantic conventions. For details on the default set of attributes that are added, checkout [Traces](#traces) and [Metrics](#metrics) sections below. diff --git a/src/OpenTelemetry.Instrumentation.Http/README.md b/src/OpenTelemetry.Instrumentation.Http/README.md index ae935dbc42..0071b4ead6 100644 --- a/src/OpenTelemetry.Instrumentation.Http/README.md +++ b/src/OpenTelemetry.Instrumentation.Http/README.md @@ -11,7 +11,7 @@ and [System.Net.HttpWebRequest](https://docs.microsoft.com/dotnet/api/system.net.httpwebrequest) and collects metrics and traces about outgoing HTTP requests. -**Note: This component is based on the +This component is based on the [v1.23](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http) of http semantic conventions. For details on the default set of attributes that are added, checkout [Traces](#traces) and [Metrics](#metrics) sections below. From 4dcf4ea841a96ee772c2817ba500fc5cda79986e Mon Sep 17 00:00:00 2001 From: Vishwesh Bankwar Date: Wed, 13 Dec 2023 14:14:12 -0800 Subject: [PATCH 7/8] fix link --- src/OpenTelemetry.Instrumentation.AspNetCore/README.md | 2 +- src/OpenTelemetry.Instrumentation.Http/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md index 1a4dfebd12..482aad252b 100644 --- a/src/OpenTelemetry.Instrumentation.AspNetCore/README.md +++ b/src/OpenTelemetry.Instrumentation.AspNetCore/README.md @@ -107,7 +107,7 @@ Following list of attributes are added by default on `http.server.request.duration` metric. See [http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) for more details about each individual attribute. `.NET8.0` and above supports -additional metrics, see [list of metrics produced](list-of-metrics-produced) for +additional metrics, see [list of metrics produced](#list-of-metrics-produced) for more details. * `error.type` diff --git a/src/OpenTelemetry.Instrumentation.Http/README.md b/src/OpenTelemetry.Instrumentation.Http/README.md index 0071b4ead6..3024c7ac80 100644 --- a/src/OpenTelemetry.Instrumentation.Http/README.md +++ b/src/OpenTelemetry.Instrumentation.Http/README.md @@ -109,7 +109,7 @@ Following list of attributes are added by default on `http.client.request.duration` metric. See [http-metrics](https://github.com/open-telemetry/semantic-conventions/tree/v1.23.0/docs/http/http-metrics.md) for more details about each individual attribute. `.NET8.0` and above supports -additional metrics, see [list of metrics produced](list-of-metrics-produced) for +additional metrics, see [list of metrics produced](#list-of-metrics-produced) for more details. * `error.type` From f36c21ffa99dfe25450f4a60c7c5169bc0968a82 Mon Sep 17 00:00:00 2001 From: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com> Date: Wed, 13 Dec 2023 19:10:53 -0800 Subject: [PATCH 8/8] Trigger CI