Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong doc information regarding http.url #5739

Closed
paulomorgado opened this issue Jul 4, 2024 · 2 comments · Fixed by #5740
Closed

Wrong doc information regarding http.url #5739

paulomorgado opened this issue Jul 4, 2024 · 2 comments · Fixed by #5740
Labels
bug Something isn't working pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Comments

@paulomorgado
Copy link

Package

OpenTelemetry

Package Version

Package Name Version
OpenTelemetry.Exporter.Console 1.9.0
OpenTelemetry.Extensions.Hosting 1.9.0
OpenTelemetry.Instrumentation.AspNetCore 1.9.0

Runtime Version

net8.0

Description

According to https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/trace/getting-started-aspnetcore/README.md, the activity should include the following activity tags:

  • net.host.name
  • net.host.port
  • http.method
  • http.scheme
  • http.target
  • http.url
  • http.flavor
  • http.user_agent
  • http.status_code

However, the activity includes the following tags:

  • server.address
  • server.port
  • http.request.method
  • url.schem
  • url.path
  • network.protocol.version
  • user_agent.original
  • http.response.status_code

Steps to Reproduce

Follow example instructions at https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/trace/getting-started-aspnetcore/README.md

Expected Result

The activity has the http.url tag.

Actual Result

The activity does not have the http.url tag.

Additional Context

No response

@paulomorgado paulomorgado added the bug Something isn't working label Jul 4, 2024
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jul 4, 2024
@paulomorgado paulomorgado changed the title Wrong doc information Wrong doc information regarding http.url Jul 4, 2024
@paulomorgado
Copy link
Author

The request activity tags is set here and it doesn't include "http.url".

@Kielek
Copy link
Contributor

Kielek commented Jul 4, 2024

@paulomorgado, http semantic convention was changed during the semantic convention stabilization process. The final step is here: open-telemetry/semantic-conventions#377

The latest stable semantic convention version is described here: https://github.com/open-telemetry/semantic-conventions/blob/v1.26.0/docs/http/http-spans.md#http-server-semantic-conventions

I do not see any obvious issues.

Documentation will be updated in #5740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants