[repo] Add Raj as approver

[CodeBlanch]

@rajkumar-rangaraj has been active in the OpenTelemetry .NET community and AppInsights community for a long time. He is a maintainer on the https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation repo, works on the AzureMonitor components, and has years of experience in telemetry working on AppInsights. I am proposing @rajkumar-rangaraj for the approver role because he has made many direct contributions to the repo but also he brings a lot of knowledge, wisdom, and experience into discussions which will benefit the review process.

[reyang]

... I am proposing @rajkumar-rangaraj for the approver role because he has made many direct contributions to the repo ...

@CodeBlanch can you provide a link to these contributions?

[CodeBlanch]

@reyang Description updated to include link to closed PRs for "direct contributions" mention.

[reyang]

@reyang Description updated to include link to closed PRs for "direct contributions" mention.

I have a hard time trying to understand what does "many" mean:

https://github.com/open-telemetry/opentelemetry-dotnet/graphs/contributors

[reyang]

It's unclear what's the criteria and how is that aligned with https://github.com/open-telemetry/community/blob/main/community-membership.md#approver.

[CodeBlanch]

Which requirement are you referring to? This one?

Reviewer for or author of at least 10 substantial PRs to the codebase, with the definition of substantial subject to the maintainer's discretion (e.g. refactors/adds new functionality rather than one-line pulls).

There is an "OR" there. Raj has made direct contributions, contributed reviews on many other contributions, and routinely joins the SIG to participate in discussion and live reviews when we look at open PRs. I have no issue passing him on this requirement whatsoever 👍

There are the areas I feel @rajkumar-rangaraj will greatly excel:

• Demonstrate sound technical judgement
• Responsible for project quality control via code reviews
  • Focus on holistic acceptance of contribution such as dependencies with other features, backwards / forwards compatibility, API and flag definitions, etc
• Mentor contributors and reviewers

[reyang]

Which requirement are you referring to? This one?

Reviewer for or author of at least 10 substantial PRs to the codebase, with the definition of substantial subject to the maintainer's discretion (e.g. refactors/adds new functionality rather than one-line pulls).

There is an "OR" there. Raj has made direct contributions, contributed reviews on many other contributions, and routinely joins the SIG to participate in discussion and live reviews when we look at open PRs. I have no issue passing him on this requirement whatsoever 👍

I understand the "OR" part, would you provide the list of PRs?

[cijothomas]

He is a maintainer on the https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation repo, works on the AzureMonitor components, and has years of experience in telemetry working on AppInsights.

While experience in related space is definitely helpful, I won't include that as a criterion for approver/maintainer in this repo. I'd suggest to see more active involvement (code reviews + code contributions) in this repo before adding as approver.

[github-actions]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.