Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove polyfill packages #5658

Closed
thompson-tomo opened this issue May 28, 2024 · 2 comments · Fixed by #5659
Closed

Remove polyfill packages #5658

thompson-tomo opened this issue May 28, 2024 · 2 comments · Fixed by #5659
Labels
enhancement New feature or request pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package

Comments

@thompson-tomo
Copy link
Contributor

Package

OpenTelemetry.Exporter.Console

Is your feature request related to a problem?

I have run into issue with System.Text.Json conflicting in the past due to being an explicit dependency

What is the expected behavior?

Only dependencies of the packages are those which can be provided by the framework ie no System.Text.Json on the newer TFM's

Which alternative solutions or features have you considered?

Accept the additional dependencies

Additional context

No response
@thompson-tomo thompson-tomo added the enhancement New feature or request label May 28, 2024
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package label May 28, 2024
@vishweshbankwar
Copy link
Member

@thompson-tomo - Would you be interested in sending the PR for this?

@thompson-tomo
Copy link
Contributor Author

@vishweshbankwar Sure I can do it in the next couple of days

thompson-tomo added a commit to thompson-tomo/opentelemetry-dotnet that referenced this issue May 29, 2024
@thompson-tomo
open-telemetry#5658 Optimise package management on newer TFM's
59991f0
@thompson-tomo thompson-tomo mentioned this issue May 29, 2024
Merged
2 tasks
thompson-tomo added a commit to thompson-tomo/opentelemetry-dotnet that referenced this issue May 29, 2024
@thompson-tomo
open-telemetry#5658 Optimise package management on newer TFM's
35b1dd7
thompson-tomo added a commit to thompson-tomo/opentelemetry-dotnet that referenced this issue May 29, 2024
@thompson-tomo
open-telemetry#5658 Optimise package management on newer TFM's
6753fdb
thompson-tomo added a commit to thompson-tomo/opentelemetry-dotnet that referenced this issue May 30, 2024
@thompson-tomo
open-telemetry#5658 Optimise package management on newer TFM's
6361ce6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[repo] Reduce explicit package references on newer TFM's thompson-tomo/opentelemetry-dotnet
2 participants
@vishweshbankwar @thompson-tomo