Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prometheus] expose prometheus with auth #2899

Closed
steinarox opened this issue Feb 15, 2022 · 3 comments
Closed

[Prometheus] expose prometheus with auth #2899

steinarox opened this issue Feb 15, 2022 · 3 comments
Labels
enhancement New feature or request metrics Metrics signal related pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package Stale Issues and pull requests which have been flagged for closing due to inactivity

Comments

@steinarox
Copy link

Feature Request

Is your feature request related to a problem?

Exposing Metrics is not desirable in most cases. If Prometheus is hosted on another machine it would be nice to support authentication in the metrics endpoint. Prometheus supports scraping with basic auth, tls certs or oauth https://prometheus.io/docs/prometheus/latest/configuration/configuration/#scrape_config

Describe the solution you'd like:

Adding one or more of the authentication modes when exposing the metrics endpoint would make it safe to expose the metrics where the Prometheus instance is hosted elsewhere

similar issues:
#2504 (otel basic aut)
#2009 (otel cert auth)
@steinarox steinarox added the enhancement New feature or request label Feb 15, 2022
@reyang reyang added pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package metrics Metrics signal related labels Feb 26, 2022
@tillig
Copy link
Contributor

tillig commented Mar 3, 2022

Related: #2776

@github-actions GitHub Actions
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request metrics Metrics signal related pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tillig @reyang @steinarox