Skip to content

Commit 91eea3a

Browse files
Merge branch 'main' into rename.dependent-services
2 parents 94682cd + 0c7c104 commit 91eea3a

6 files changed

+27
-5
lines changed

.env.arm64

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
_JAVA_OPTIONS=-XX:UseSVE=0

Makefile

+12-3
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,15 @@ MISSPELL = $(TOOLS_DIR)/$(MISSPELL_BINARY)
1212

1313
DOCKER_COMPOSE_CMD ?= docker compose
1414
DOCKER_COMPOSE_ENV=--env-file .env --env-file .env.override
15+
DOCKER_COMPOSE_BUILD_ARGS=
16+
17+
# Java Workaround for macOS 15.2+ and M4 chips (see https://bugs.openjdk.org/browse/JDK-8345296)
18+
ifeq ($(shell uname -m),arm64)
19+
ifeq ($(shell uname -s),Darwin)
20+
DOCKER_COMPOSE_ENV+= --env-file .env.arm64
21+
DOCKER_COMPOSE_BUILD_ARGS+= --build-arg=_JAVA_OPTIONS=-XX:UseSVE=0
22+
endif
23+
endif
1524

1625
# see https://github.com/open-telemetry/build-tools/releases for semconvgen updates
1726
# Keep links in semantic_conventions/README.md and .vscode/settings.json in sync!
@@ -77,11 +86,11 @@ install-tools: $(MISSPELL)
7786

7887
.PHONY: build
7988
build:
80-
$(DOCKER_COMPOSE_CMD) build
89+
$(DOCKER_COMPOSE_CMD) build $(DOCKER_COMPOSE_BUILD_ARGS)
8190

8291
.PHONY: build-and-push
8392
build-and-push:
84-
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) build --push
93+
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) build $(DOCKER_COMPOSE_BUILD_ARGS) --push
8594

8695
# Create multiplatform builder for buildx
8796
.PHONY: create-multiplatform-builder
@@ -209,7 +218,7 @@ ifdef SERVICE
209218
endif
210219

211220
ifdef service
212-
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) build $(service)
221+
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) build $(DOCKER_COMPOSE_BUILD_ARGS) $(service)
213222
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) stop $(service)
214223
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) rm --force $(service)
215224
$(DOCKER_COMPOSE_CMD) $(DOCKER_COMPOSE_ENV) create $(service)

docker-compose.minimal.yml

+4
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ services:
4444
- OTEL_RESOURCE_ATTRIBUTES
4545
- OTEL_LOGS_EXPORTER=otlp
4646
- OTEL_SERVICE_NAME=ad
47+
# Workaround on OSX for https://bugs.openjdk.org/browse/JDK-8345296
48+
- _JAVA_OPTIONS
4749
depends_on:
4850
otel-collector:
4951
condition: service_started
@@ -654,6 +656,8 @@ services:
654656
- OPENSEARCH_JAVA_OPTS=-Xms300m -Xmx300m
655657
- DISABLE_INSTALL_DEMO_CONFIG=true
656658
- DISABLE_SECURITY_PLUGIN=true
659+
# Workaround on OSX for https://bugs.openjdk.org/browse/JDK-8345296
660+
- _JAVA_OPTIONS
657661
ulimits:
658662
memlock:
659663
soft: -1

docker-compose.yml

+6
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ services:
7171
- OTEL_RESOURCE_ATTRIBUTES
7272
- OTEL_LOGS_EXPORTER=otlp
7373
- OTEL_SERVICE_NAME=ad
74+
# Workaround on OSX for https://bugs.openjdk.org/browse/JDK-8345296
75+
- _JAVA_OPTIONS
7476
depends_on:
7577
otel-collector:
7678
condition: service_started
@@ -658,6 +660,8 @@ services:
658660
- OTEL_RESOURCE_ATTRIBUTES
659661
- OTEL_SERVICE_NAME=kafka
660662
- KAFKA_HEAP_OPTS=-Xmx400m -Xms400m
663+
# Workaround on OSX for https://bugs.openjdk.org/browse/JDK-8345296
664+
- _JAVA_OPTIONS
661665
healthcheck:
662666
test: nc -z kafka 9092
663667
start_period: 10s
@@ -798,6 +802,8 @@ services:
798802
- OPENSEARCH_JAVA_OPTS=-Xms300m -Xmx300m
799803
- DISABLE_INSTALL_DEMO_CONFIG=true
800804
- DISABLE_SECURITY_PLUGIN=true
805+
# Workaround on OSX for https://bugs.openjdk.org/browse/JDK-8345296
806+
- _JAVA_OPTIONS
801807
ulimits:
802808
memlock:
803809
soft: -1

src/ad/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44

55
FROM --platform=${BUILDPLATFORM} eclipse-temurin:21-jdk AS builder
6-
6+
ARG _JAVA_OPTIONS
77
WORKDIR /usr/src/app/
88

99
COPY ./src/ad/gradlew* ./src/ad/settings.gradle* ./src/ad/build.gradle ./
@@ -23,6 +23,8 @@ RUN ./gradlew installDist -PprotoSourceDir=./proto
2323
FROM eclipse-temurin:21-jre
2424

2525
ARG OTEL_JAVA_AGENT_VERSION
26+
ARG _JAVA_OPTIONS
27+
2628
WORKDIR /usr/src/app/
2729

2830
COPY --from=builder /usr/src/app/ ./

src/flagd/demo.flagd.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"on": true,
4545
"off": false
4646
},
47-
"defaultVariant": "on"
47+
"defaultVariant": "off"
4848
},
4949
"kafkaQueueProblems": {
5050
"description": "Overloads Kafka queue while simultaneously introducing a consumer side delay leading to a lag spike",

0 commit comments

Comments
 (0)