how do I set the service.name on a metric?

[willie]

Traces and Logs have the ability to pass in a resource (where you can supply a service.name) to their respective provider factories. How do I do this with a Metrics provider?

[lalitb]

As of now, you need to use:

opentelemetry-cpp/sdk/include/opentelemetry/sdk/metrics/meter_provider_factory.h

Lines 67 to 69 in c82306f

	static std::unique_ptr<opentelemetry::metrics::MeterProvider> Create(
	std::unique_ptr<ViewRegistry> views,
	const opentelemetry::sdk::resource::Resource &resource);

and perhaps pass an empty ViewRegistry. I believe there should be a much simpler approach to be supported.

ps. You can also set it using env-variable OTEL_RESOURCE_ATTRIBUTES.

[willie]

(Let me know if I need to write a new discussion question instead of continuing the thought here.)

I wrote the code and I wrote a test, but I can't figure out how to run the test. Do you have any suggestions? Here what I tried, for example (per the CI instructions):

% ./ci/run_docker.sh ./ci/do_ci.sh bazel.test
mkdir: cannot create directory '//build': Permission denied

If I run it directly on my Mac, I eventually get:

% ./ci/do_ci.sh cmake.test
[...]
CMake Error at /usr/local/Cellar/cmake/3.27.9/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
  GTEST_MAIN_LIBRARY)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.27.9/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/Cellar/cmake/3.27.9/share/cmake/Modules/FindGTest.cmake:270 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:609 (find_package)

If I try bazel on my Mac:

% ./ci/do_ci.sh bazel.test
make command: make -k -j $(nproc)
IWYU option: 
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
ERROR: error loading package 'bazel-opentelemetry-cpp/external/bazel_tools/tools/jdk': Every .bzl file must have a corresponding package, but '//tools/jdk:java_toolchain_alias.bzl' does not have one. Please create a BUILD file in the same or any parent directory. Note that this BUILD file does not need to do anything except exist.
INFO: Elapsed time: 12.313s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (18 packages loaded)
    currently loading: bazel-opentelemetry-cpp/external/bazel_tools/tools/jdk ... (9 packages)

If I load the docker image, I get this error eventually:

% ./ci/run_docker.sh  
root@96792dac5914:/src# ./ci/do_ci.sh bazel.test
[...]
ERROR: /src/opentracing-shim/BUILD:92:8: Compiling opentracing-shim/test/tracer_shim_test.cc failed: (Exit 1): gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer '-std=c++0x' -MD -MF ... (remaining 53 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
opentracing-shim/test/tracer_shim_test.cc: In member function 'virtual void TracerShimTest_SpanHandleErrorTagAtCreation_Test::TestBody()':
opentracing-shim/test/tracer_shim_test.cc:105:95: error: no matching function for call to 'opentracing::v3::Tracer::StartSpanWithOptions(const char [6], <brace-enclosed initializer list>)'
   auto span_shim1 = tracer_shim->StartSpanWithOptions("test1", {.tags = {{"event", "normal"}}});
                                                                                               ^
In file included from bazel-out/k8-fastbuild/bin/opentracing-shim/_virtual_includes/opentracing_shim/opentelemetry/opentracingshim/shim_utils.h:12:0,
                 from opentracing-shim/test/tracer_shim_test.cc:8:
bazel-out/k8-fastbuild/bin/external/com_github_opentracing/_virtual_includes/opentracing/opentracing/tracer.h:101:33: note: candidate: virtual std::unique_ptr<opentracing::v3::Span> opentracing::v3::Tracer::StartSpanWithOptions(opentracing::v3::string_view, const opentracing::v3::StartSpanOptions&) const
   virtual std::unique_ptr<Span> StartSpanWithOptions(
                                 ^~~~~~~~~~~~~~~~~~~~
bazel-out/k8-fastbuild/bin/external/com_github_opentracing/_virtual_includes/opentracing/opentracing/tracer.h:101:33: note:   no known conversion for argument 2 from '<brace-enclosed initializer list>' to 'const opentracing::v3::StartSpanOptions&'
opentracing-shim/test/tracer_shim_test.cc:110:91: error: no matching function for call to 'opentracing::v3::Tracer::StartSpanWithOptions(const char [6], <brace-enclosed initializer list>)'
   auto span_shim2 = tracer_shim->StartSpanWithOptions("test2", {.tags = {{"error", true}}});
                                                                                           ^
In file included from bazel-out/k8-fastbuild/bin/opentracing-shim/_virtual_includes/opentracing_shim/opentelemetry/opentracingshim/shim_utils.h:12:0,
                 from opentracing-shim/test/tracer_shim_test.cc:8:
bazel-out/k8-fastbuild/bin/external/com_github_opentracing/_virtual_includes/opentracing/opentracing/tracer.h:101:33: note: candidate: virtual std::unique_ptr<opentracing::v3::Span> opentracing::v3::Tracer::StartSpanWithOptions(opentracing::v3::string_view, const opentracing::v3::StartSpanOptions&) const
   virtual std::unique_ptr<Span> StartSpanWithOptions(
                                 ^~~~~~~~~~~~~~~~~~~~
bazel-out/k8-fastbuild/bin/external/com_github_opentracing/_virtual_includes/opentracing/opentracing/tracer.h:101:33: note:   no known conversion for argument 2 from '<brace-enclosed initializer list>' to 'const opentracing::v3::StartSpanOptions&'
opentracing-shim/test/tracer_shim_test.cc:115:94: error: no matching function for call to 'opentracing::v3::Tracer::StartSpanWithOptions(const char [6], <brace-enclosed initializer list>)'
   auto span_shim3 = tracer_shim->StartSpanWithOptions("test3", {.tags = {{"error", "false"}}});
                                                                                              ^
In file included from bazel-out/k8-fastbuild/bin/opentracing-shim/_virtual_includes/opentracing_shim/opentelemetry/opentracingshim/shim_utils.h:12:0,
                 from opentracing-shim/test/tracer_shim_test.cc:8:
bazel-out/k8-fastbuild/bin/external/com_github_opentracing/_virtual_includes/opentracing/opentracing/tracer.h:101:33: note: candidate: virtual std::unique_ptr<opentracing::v3::Span> opentracing::v3::Tracer::StartSpanWithOptions(opentracing::v3::string_view, const opentracing::v3::StartSpanOptions&) const
   virtual std::unique_ptr<Span> StartSpanWithOptions(
                                 ^~~~~~~~~~~~~~~~~~~~
bazel-out/k8-fastbuild/bin/external/com_github_opentracing/_virtual_includes/opentracing/opentracing/tracer.h:101:33: note:   no known conversion for argument 2 from '<brace-enclosed initializer list>' to 'const opentracing::v3::StartSpanOptions&'
INFO: Elapsed time: 615.162s, Critical Path: 40.18s
INFO: 4755 processes: 1632 internal, 3123 linux-sandbox.
FAILED: Build did NOT complete successfully

[lalitb]

If you are using cmake, you can do it as indicated in the INSTALL.md:

$ cd <repo>
$ mkdir build && cd build
$ cmake ..  
$ cmake --build . --target all 
$ ctest

[willie]

I forgot to mention I tried that, too. I don't normally run gtest, so 🤷. This is on my Mac. I'll try from the docker CI image.

% cmake ..
CMake Deprecation Warning at CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- Building for architecture ARCH=x64
-- OPENTELEMETRY_ABI_VERSION_NO=1
-- OPENTELEMETRY_VERSION=1.14.2
CMake Error at /usr/local/Cellar/cmake/3.27.9/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR
  GTEST_MAIN_LIBRARY)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.27.9/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/Cellar/cmake/3.27.9/share/cmake/Modules/FindGTest.cmake:270 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:609 (find_package)

-- Configuring incomplete, errors occurred!

[lalitb]

Ok, I don't have Mac to try this out, but this works for me from ubuntu machine:

$ ./ci/run_docker.sh
root@d0f3ca1b8462:/src# cd build
root@7510154d54a0:/src/build# cmake .. -DWITH_BENCHMARK=OFF
root@7510154d54a0:/src/build# make -j${nproj}
root@7510154d54a0:/src/build# make test

[willie]

-DWITH_BENCHMARK=OFF

This resolved my problem on Linux. The problem remained on Mac, turns out Google Test wasn't installed even though I thought it was since there was a gtest at /usr/local/bin/gtest on my system. And then it resolved the problem everywhere. Thanks for all the help. (Update: The gtest that was installed is part of GNU Coreutils.)