Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move partial goreleaser config to Go code #735

Open
mowies opened this issue Nov 14, 2024 · 2 comments · May be fixed by #758
Open

Move partial goreleaser config to Go code #735

mowies opened this issue Nov 14, 2024 · 2 comments · May be fixed by #758

Comments

@mowies
Copy link
Member

mowies commented Nov 14, 2024 •
edited
Loading

The partial configuration option for the goreleaser files was hardcoded in #478 as a hack/workaround. Since the goreleaser Go config was updated in goreleaser/goreleaser#4635 and released, we can now move this to Go code next to the other configuration options now.

Example of config section:

opentelemetry-collector-releases/distributions/otelcol-contrib/.goreleaser.yaml

Lines 1 to 2 in ee3ebeb

partial:
by: target

@mowies
Copy link
Member Author

mowies commented Nov 25, 2024

i'll work on this

@mowies mowies mentioned this issue Nov 25, 2024
Closed
@mowies mowies linked a pull request Dec 4, 2024 that will close this issue
Open
@mowies
Copy link
Member Author

mowies commented Dec 4, 2024

PR is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mowies