Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and delete the githubgen utility in favor of the code now living in opentelemetry-go-build-tools #37294

Open
2 of 4 tasks
atoulme opened this issue Jan 17, 2025 · 1 comment
Open
2 of 4 tasks

Deprecate and delete the githubgen utility in favor of the code now living in opentelemetry-go-build-tools #37294

atoulme opened this issue Jan 17, 2025 · 1 comment
Labels
cmd/githubgen

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 17, 2025 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

The githubgen tool has moved to opentelemetry-go-build-tools and should be removed from this repository.

  • Deprecate the code and add a warning
  • Move all existing issues related to githubgen to the new repository
  • Stop using the githubgen tool in our CI/CD across all repositories managed by the opentelemetry organization
  • Delete the code after a period of time
@atoulme atoulme added needs triage New item requiring triage cmd/githubgen and removed needs triage New item requiring triage labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for cmd/githubgen: @atoulme. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

This was referenced Jan 17, 2025
Merged
Merged
songy23 pushed a commit that referenced this issue Jan 17, 2025
@atoulme
[githubgen] Deprecate githubgen in favor of opentelemetry-go-build-to…
25912dc 
…ols (#37295)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Deprecates githubgen in favor of the new location of this code under
opentelemetry-go-build-tools

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Related to #37294
@github-actions github-actions bot mentioned this issue Jan 21, 2025
Open
@atoulme atoulme mentioned this issue Jan 21, 2025
Merged
songy23 pushed a commit that referenced this issue Jan 22, 2025
@atoulme
[chore] switch over githubgen to the one built with our tools (#37397)
fafdfdd 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Change the githubgen we use to the one defined in
opentelemetry-go-build-tools

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
See
#37294
@mowies mowies mentioned this issue Jan 23, 2025
Merged
songy23 pushed a commit that referenced this issue Jan 23, 2025
@mowies
Use githubgen tool from go-build-tools (#37412)
b731208 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
- This PR
- switches over all usages of the githubgen tool to the new tool
location by adjusting make targets and the check-code-owners pipeline
  - introduces the new githubgen tool at its latest v0.17.0 version 
- adds `make gengithub` to the commands to run in the contribution guide
- re-generates the codeowners and allowlist files using the new
githubgen tool (only cosmetic changes)

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
#37294


<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
@atoulme @chengchuanpeng
[githubgen] Deprecate githubgen in favor of opentelemetry-go-build-to…
2ba14df 
…ols (open-telemetry#37295)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Deprecates githubgen in favor of the new location of this code under
opentelemetry-go-build-tools

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Related to open-telemetry#37294
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
@atoulme @chengchuanpeng
[chore] switch over githubgen to the one built with our tools (open-t…
5936130 
…elemetry#37397)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Change the githubgen we use to the one defined in
opentelemetry-go-build-tools

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
See
open-telemetry#37294
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
@mowies @chengchuanpeng
Use githubgen tool from go-build-tools (open-telemetry#37412)
67d404b 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
- This PR
- switches over all usages of the githubgen tool to the new tool
location by adjusting make targets and the check-code-owners pipeline
  - introduces the new githubgen tool at its latest v0.17.0 version 
- adds `make gengithub` to the commands to run in the contribution guide
- re-generates the codeowners and allowlist files using the new
githubgen tool (only cosmetic changes)

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Part of
open-telemetry#37294


<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies mentioned this issue Jan 27, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/githubgen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atoulme