Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release] make update-otel does not commit the tidy changes #36854

Closed
songy23 opened this issue Dec 16, 2024 · 0 comments · Fixed by #36855
Closed

[release] make update-otel does not commit the tidy changes #36854

songy23 opened this issue Dec 16, 2024 · 0 comments · Fixed by #36855
Labels
release-retro Issues discussed in a release retrospective

Comments

@songy23
Copy link
Member

songy23 commented Dec 16, 2024

Component(s)

No response

Describe the issue you're reporting

E.g. in #36851 I had to manually run and commit make gotidy

opentelemetry-collector-contrib/Makefile

Line 419 in be56910

$(MAKE) gotidy
is missing a following git commit
@songy23 songy23 added the release-retro Issues discussed in a release retrospective label Dec 16, 2024
@songy23 songy23 mentioned this issue Dec 16, 2024
Merged
mx-psi pushed a commit that referenced this issue Dec 16, 2024
@songy23
[chore] make update-otel should commit tidy changes (#36855)
a8821cd 
#### Description
`make update-otel` should commit tidy changes

#### Link to tracking issue
Fixes
#36854
@github-actions github-actions bot mentioned this issue Dec 17, 2024
Open
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@songy23 @sbylica-splunk
[chore] make update-otel should commit tidy changes (open-telemetry#3…
4799442 
…6855)

#### Description
`make update-otel` should commit tidy changes

#### Link to tracking issue
Fixes
open-telemetry#36854
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this issue Dec 19, 2024
@songy23 @mterhar
[chore] make update-otel should commit tidy changes (open-telemetry#3…
d8854a8 
…6855)

#### Description
`make update-otel` should commit tidy changes

#### Link to tracking issue
Fixes
open-telemetry#36854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release-retro Issues discussed in a release retrospective
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] make update-otel should commit tidy changes songy23/opentelemetry-service-contrib
1 participant
@songy23