Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out subcategories of manipulators, observers and executions into child classes #5

Open
msteinsto opened this issue Apr 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@msteinsto
Copy link
Contributor

There is currently a singular parent class for CosimManipulator, CosimObserver and CosimExecution objects. Initializing each of them currently uses a non-Pythonic [ClassName].from_[specific_object] or [ClassName].create_[specific_object] approach.

This enhancement would also allow functions such as start_time_series to be renamed to start while making it more intuitive to use (all functions within a class will be relevant and can be applied to the object).

Suggested parent class and new child class split:

  • CosimManipulator -> OverrideManipulator, ScenarioManagerManipulator
  • CosimObserver -> LastValueObserver, ToDirectoryObserver, TimeSeriesObserver
  • CosimExecution -> CosimExecution, OspConfigExecution, SspExecution
@msteinsto msteinsto added the enhancement New feature or request label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant