-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete roundtrip of PL <--> OPB MD conversion #87
base: main
Are you sure you want to change the base?
Conversation
Does not try to retain assets, or defined asset values, and loses the types of non string customizations currently.
- Add missing section to md result we cannot roundtrip right now - Move imports to a dedicated sections with a comment - Using `ast.literal_eval`, customizations that are literals are parsed back from strings to their native type
now attempts to list assets found in the 4 key folders from prairielearn
Need to flatten the namedtuple to a list
- Now copies asset files - Allows for an output directory and filename to be passed - Validates input paths are directories and not files - Improves argument checking
Benchmark of what output looks like as of August 11th, 2023: https://gist.github.com/Bluesy1/6f497bc1ed5b4a3aae25f91918abe2ad |
- Need to prevent `"..."` from being evaled to the `Ellipses` literal - Remove the `__pycache__` directory created by importing and executing the `server.py` file - Fix `server.py` parsing - Fix asset copying - Add `pl-rich-text-editor` to list of supported pl inputs
Now should upload md generated from pl files on failure
…metadata field of the comment object in `info.json`
For now, to make the roundtrip possible, I've shoved all the extra keys I can't get normally into a nested object inside the comment section of the I expect this will need multiple rounds of review since its a fairly large change, but it should be mostly feature complete now and working. |
Start fixing bugs/issues in tests causing failures
…if one on a question already fails.
5d27a03
to
5e18acf
Compare
Complete the PL to/from OPB MD roundtrip
TODO:
Resolves #86