Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "temporary" Layers #258

Open
mbeckem opened this issue Jan 16, 2024 · 0 comments
Open

Refactor "temporary" Layers #258

mbeckem opened this issue Jan 16, 2024 · 0 comments

Comments

@mbeckem
Copy link
Contributor

mbeckem commented Jan 16, 2024

Various packages currently need (mostly temporary) OpenLayers layers to implement their functionality.
Examples are measurement (for measurement geometries), map model (for highlight geometries) and geolocation (for the location geometry).

These layers share some common properties:

  • They are considered internal (e.g. should usually not be shown in the TOC)
  • They are "always on top"
  • They are vector layers

The currently existing implementations create simple ad hoc OpenLayers layer instances (i.e. new VectorLayer()) and assign a very high z-index for the "always on top" feature. In other words, this approach currently bypasses our map model.

Instead of using raw OpenLayers instances, we should use "real" layer objects instead:

  • This is an opportunity to handle "always on top" centrally and remove the z-index hack
  • It enables future features such as showing a sketch layer in the TOC under certain circumstances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant