Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] The code and documentation are really terrible[Docs] #2112

Open
TheHonestBob opened this issue Jan 9, 2024 · 3 comments
Open

[Feature] The code and documentation are really terrible[Docs] #2112

TheHonestBob opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
kind/doc fix, add or improve documentations

Comments

@TheHonestBob
Copy link

Branch

main branch https://mmagic.readthedocs.io/en/latest/

📚 The doc issue

when I use MMagicInferencer, I cannot specify any parameters, or in other words, after reading many levels of source code, I still cannot know which parameters I should pass in. For example, during VSR inference tasks, I cannot specify fps. For a 1920 * 1080 video with only 25 frames, it is OOM on a 24G 4090

Suggest a potential alternative/fix

No response

@TheHonestBob TheHonestBob added the kind/doc fix, add or improve documentations label Jan 9, 2024
@limhasic
Copy link

Even though it hasn't been made yet, isn't it great to be able to gather all the references and get an idea of ​​what's out there?

@kvnsng
Copy link

kvnsng commented Jun 13, 2024

Running into same OOM issues using MMagicInferencer... Any documentations on how to limit overloading the memory?

@rlewkowicz
Copy link

I think we have to monkey patch it. I also have these issues.
https://www.geeksforgeeks.org/monkey-patching-in-python-dynamic-behavior/

Among other things, you also cant pass a save path and mmengine complains. I've never been able to get these aios to work. It's always more time saving to go papers with code and just write my own for the single thing I need. I would love this stuff to work. paddle paddle feels the same.

But if I have to do all the work to read all of it to understand it, at that point I can just go write it faster with less complexity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/doc fix, add or improve documentations
Projects
None yet
Development

No branches or pull requests

5 participants