Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot autocomplete ipv6 portals #20

Closed
cvubrugier opened this issue Nov 15, 2015 · 1 comment
Closed

Cannot autocomplete ipv6 portals #20

cvubrugier opened this issue Nov 15, 2015 · 1 comment
Assignees
@cvubrugier

Comments

@cvubrugier
Copy link
Collaborator

From the original bug report from @agrover: https://lists.fedorahosted.org/pipermail/targetcli-fb-devel/2015-November/000190.html

We bracket iscsi ipv6 portals, so after creating one, it will show up in targetcli like

o- portals
o- [::]:3260

But, if I type "cd [" it doesn't autocomplete.

I will provide a fix.
@cvubrugier cvubrugier self-assigned this Nov 15, 2015
cvubrugier added a commit to cvubrugier/configshell-fb that referenced this issue Nov 15, 2015
@cvubrugier
Fix completion of IPv6 portals
81aec24 
Allow square brackets in parameters and remove them from readline's
set_completer_delims() so that readline does not remove the square
brackets from the "text" argument in _complete_token_pparam()

This patch fixes issue open-iscsi#20.

Signed-off-by: Christophe Vu-Brugier <[email protected]>
@cvubrugier cvubrugier mentioned this issue Nov 15, 2015
Merged
@agrover agrover closed this as completed Nov 15, 2015
@rldleblanc
Copy link

This doesn't fix all of the IPv6 issues. Please see Issue #34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvubrugier cvubrugier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agrover @cvubrugier @rldleblanc