Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1292 temperature slab on ground #1358

Merged
merged 12 commits into from
Jun 10, 2024
Merged

Issue1292 temperature slab on ground #1358

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e318d32
correct typo
lucasverleyen Mar 27, 2024
6231639
add parameter T_start_ground for initial temperature of the ground
lucasverleyen Mar 27, 2024
601d5f9
add T_start_ground to rectangular zone interface
lucasverleyen Mar 27, 2024
679e035
Merge branch 'master' into issue1292_temperatureSlabOnGround
lucasverleyen Apr 19, 2024
9732ce4
use final protected parameter and update naming
lucasverleyen May 16, 2024
348c974
update documentation
lucasverleyen May 16, 2024
4e56fb4
update rectangular zone template accordingly
lucasverleyen May 16, 2024
a5318f4
Fix wrong parameter in annotation
jelgerjansen May 29, 2024
e6ddb84
Merge branch 'master' into issue1292_temperatureSlabOnGround
lucasverleyen May 31, 2024
d920f61
change explicit array to fill() function
lucasverleyen May 31, 2024
8235ed5
Update github-actions.yml
louisher Jun 3, 2024
d555214
Update github-actions.yml
louisher Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions IDEAS/Buildings/Components/Interfaces/RectangularZoneTemplateInterface.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ partial model RectangularZoneTemplateInterface
parameter SI.TemperatureDifference dTiAvg=2
"Amplitude of variation of monthly average indoor temperature"
annotation(Dialog(tab="Floor", group="Slab on ground", enable=(bouTypFlo == IDEAS.Buildings.Components.Interfaces.BoundaryType.SlabOnGround)));
parameter Modelica.Units.SI.Temperature T_start_gro[3]={TeAvg,TeAvg,TeAvg}
"Initial temperatures of the ground layers (with first value = deepest layer
and last value = shallowest layer"
annotation(Evaluate=true,Dialog(tab="Floor", group="Slab on ground", enable=(bouTypFlo == IDEAS.Buildings.Components.Interfaces.BoundaryType.SlabOnGround)));
parameter SI.TemperatureDifference dT_nominal_intA=1
"Nominal temperature difference between zone air and interior walls, used for linearisation"
annotation(Dialog(tab="Advanced", group="Convective heat transfer"));
Expand Down Expand Up @@ -717,6 +721,7 @@ partial model RectangularZoneTemplateInterface
redeclare package Medium = Medium,
TeAvg=TeAvg,
TiAvg=TiAvg,
T_start_gro=T_start_gro,
dTeAvg=dTeAvg,
dTiAvg=dTiAvg,
dT_nominal_a=dT_nominal_sla,
Expand Down Expand Up @@ -1510,6 +1515,12 @@ components cannot be propagated.
</html>", revisions="<html>
<ul>
<li>
March 27, 2024, by Lucas Verleyen:<br>
Added parameter <code>T_start_gro</code> for initial temperature of the ground (<code>layGro</code>).<br>
According to the changes in SlabOnGround.<br>
See <a href=https://github.com/open-ideas/IDEAS/issues/1292>#1292</a> for more information.
</li>
<li>
January 8, 2024, by Jelger Jansen:<br/>
Removed duplicate declaration of <code>mSenFac</code>.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1343\">
Expand Down
14 changes: 12 additions & 2 deletions IDEAS/Buildings/Components/SlabOnGround.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ model SlabOnGround "opaque floor on ground slab"
"Annual average outdoor temperature";
parameter Modelica.Units.SI.Temperature TiAvg=273.15 + 22
"Annual average indoor temperature";
parameter Modelica.Units.SI.Temperature T_start_gro[nLayGro]=fill(TeAvg, nLayGro)
"Initial temperatures of the ground layers (with first value = deepest layer
and last value = shallowest layer"
annotation(Evaluate=true,Dialog(tab="Dynamics", group="Initial condition"));
parameter Modelica.Units.SI.TemperatureDifference dTeAvg=4
"Amplitude of variation of monthly average outdoor temperature";
parameter Modelica.Units.SI.TemperatureDifference dTiAvg=2
Expand Down Expand Up @@ -65,12 +69,13 @@ protected
final parameter Real Lpi=A *ground1.k/dt*sqrt(1/((1 + delta/dt)^2 + 1));
final parameter Real Lpe=0.37*PWall*ground1.k*log(delta/dt + 1);
Real m = sim.solTim.y/3.1536e7*12 "time in months";
final parameter Integer nLayGro = layGro.nLay "Number of ground layers";

BaseClasses.ConductiveHeatTransfer.MultiLayer layGro(
final inc=incInt,
final nLay=3,
final mats={ground1,ground2,ground3},
final T_start={TeAvg,TeAvg,TeAvg},
final T_start=T_start_gro,
monLay(each energyDynamics=energyDynamics),
final A=A)
"Declaration of array of resistances and capacitances for ground simulation"
Expand Down Expand Up @@ -169,13 +174,18 @@ for equations, options, parameters, validation and dynamics that are common for
<p>
The model contains several parameters that are used
to set up a simplified model of the influence of the
environment on the ground themperature.
environment on the ground temperature.
The model assumes that the floor plate is connected to a (heated)
zone that is surrounded by air at the ambient temperature.
</p>
</html>", revisions="<html>
<ul>
<li>
May 16, 2024, by Lucas Verleyen:<br>
Created final and protected parameter <code>T_start_gro</code> for initial temperature of the ground (<code>layGro</code>).<br>
See <a href=https://github.com/open-ideas/IDEAS/issues/1292>#1292</a> for more information.
</li>
<li>
April 26, 2020, by Filip Jorissen:<br/>
Refactored <code>SolBus</code> to avoid many instances in <code>PropsBus</code>.
See <a href=\"https://github.com/open-ideas/IDEAS/issues/1131\">
Expand Down
Loading