Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerfectGas and fix for 1-port TrickleVent #1353

Merged
merged 3 commits into from
Feb 20, 2024
Merged

PerfectGas and fix for 1-port TrickleVent #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72d5a63
PerfectGas medium in 2storeyboxes model
kldjonge Feb 20, 2024
bb087dd
Fix for tricklevent connect (was not connected) and for when 1-port i…
kldjonge Feb 20, 2024
998d619
Addition of 1-port model without trickleVent
kldjonge Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions IDEAS/Buildings/Components/Validations/AirflowBoxModel.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@ model AirflowBoxModel
extends Modelica.Icons.Example;


Box_Sim Energy_Only(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None)) annotation (Placement(transformation(rotation=0, extent={{-82,18},{-22,78}})));
Box_Sim Energy_Only(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None)) annotation (Placement(transformation(rotation=0, extent={{-124,16},
{-64,76}})));
Box_Sim Energy_n50Corr(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.None, unify_n50=true)) annotation (Placement(transformation(rotation=0,
extent={{20,20},{80,80}})));
Box_Sim IAQ_1port(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.OnePort), winD(
extent={{-22,18},{38,78}})));
Box_Sim IAQ_1port(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.OnePort))
annotation (Placement(transformation(rotation=0, extent={{-164,-82},{-104,-22}})));
Box_Sim IAQ_1port_trickle(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.OnePort),
winD(
use_trickle_vent=true,
m_flow_nominal=50*1.2041/3600,
dp_nominal=2)) annotation (Placement(transformation(rotation=0,extent={{-80,-80},{-20,-20}})));
dp_nominal=2)) annotation (Placement(transformation(rotation=0, extent={{-80,
-80},{-20,-20}})));
Box_Sim IAQ_2Port(sim(interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts),
use_operable_window=true,
winD(crackOrOperableDoor(nCom=2),
Expand Down Expand Up @@ -114,5 +119,7 @@ protected
__Dymola_Algorithm="Dassl"), Documentation(info="<html>
This model runs the 4 possible interzonal airflow configurations of a simple box model. Temperature is kept constant at 18° degrees

</html>"));
</html>"),
Diagram(coordinateSystem(extent={{-180,-100},{100,100}})),
Icon(coordinateSystem(extent={{-180,-100},{100,100}})));
end AirflowBoxModel;
2 changes: 2 additions & 0 deletions IDEAS/Buildings/Components/Validations/TwoStoreyBoxes.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ model TwoStoreyBoxes
annotation (Placement(transformation(extent={{-100,80},{-80,100}})));

RectangularZoneTemplate Level(
redeclare package Medium = IDEAS.Media.Specialized.Air.PerfectGas,
hFloor=5,
T_start=291.15,
bouTypA=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
Expand All @@ -27,6 +28,7 @@ model TwoStoreyBoxes
annotation (Placement(transformation(extent={{-40,20},{-20,40}})));

RectangularZoneTemplate Groundfloor(
redeclare package Medium = IDEAS.Media.Specialized.Air.PerfectGas,
T_start=291.15,
bouTypA=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
bouTypB=IDEAS.Buildings.Components.Interfaces.BoundaryType.OuterWall,
Expand Down
6 changes: 6 additions & 0 deletions IDEAS/Buildings/Components/Window.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,12 @@ equation
connect(outside_trickleCol.port_b, outsideAir.ports[if sim.interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts then 3 else 2]) annotation (
Line(points={{18,-102},{18,-110},{6,-110},{6,-80},{-20,-80}},
color = {0, 127, 255}));
connect(outside_trickleCol.port_a, trickleVent.port_a)
annotation (Line(points={{18,-82},{18,-80},{26,-80}}, color={0,127,255}));
if sim.interZonalAirFlowType == IDEAS.BoundaryConditions.Types.InterZonalAirFlow.OnePort and use_trickle_vent then
connect(outsideAir.ports[2], trickleVent.port_a) annotation (Line(points={{-20,-80},
{-20,-80},{26,-80}}, color={0,127,255}));
end if;
connect(y_window_trunc.y, solWin.y) annotation (
Line(points={{-10,-79},{-10,-58}}, color = {0, 0, 127}));
connect(y_window_trunc.y, crackOrOperableDoor.y) annotation (
Expand Down
Loading